Skip to content

Commit b41cf3b

Browse files
committed
AnimationManager.frameName setter wasn't checking if _frameData existed before accessing it (thanks @nesukun phaserjs#1727)
1 parent 0aaa77a commit b41cf3b

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,10 +246,13 @@ Version 2.3.1 - "Katar" - in dev
246246

247247
### New Features
248248

249+
* Tilemap.getTileWorldXY has a new optional parameter: `nonNull` which if set makes it behave in the same way as `getTile` does (thanks @GGAlanSmithee #1722)
250+
249251
### Updates
250252

251-
* TypeScript definitions fixes and updates (thanks @clark-stevenson @isuda)
253+
* TypeScript definitions fixes and updates (thanks @clark-stevenson @isuda @ggarek)
252254
* Added missing `resumed` method to Phaser.State class template.
255+
* Color.webToColor and Color.updateColor now updates the `out.color` and `out.color32` properties (thanks @cuixiping #1728)
253256

254257
### Bug Fixes
255258

@@ -258,6 +261,9 @@ Version 2.3.1 - "Katar" - in dev
258261
* Sprite was missing the Health and InCamera components.
259262
* A Tween could be incorrectly set to never end if it was given a duration of zero (thanks @hardalias #1710)
260263
* Added guards around `context.getImageData` calls in BitmapData, Text and Canvas Tinting classes to avoid crashing restricted browsers like Epic Browser. Please understand that several Phaser features won't work correctly with this browser (thanks @Erik3000 #1714)
264+
* P2 Body.destroy now checks for the existence of a `sprite` property on the body before nulling it (thanks @englercj #1736)
265+
* The version of p2.js being used in 2.3.0 wasn't correctly declaring itself as a global for browserify / requireJS. This update resolves that (thanks @dgoemans #1723)
266+
* AnimationManager.frameName setter wasn't checking if `_frameData` existed before accessing it (thanks @nesukun #1727)
261267

262268
For changes in previous releases please see the extensive [Version History](https://github.com/photonstorm/phaser/blob/master/CHANGELOG.md).
263269

src/animation/AnimationManager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ Object.defineProperty(Phaser.AnimationManager.prototype, 'frameName', {
569569

570570
set: function (value) {
571571

572-
if (typeof value === 'string' && this._frameData.getFrameByName(value) !== null)
572+
if (typeof value === 'string' && this._frameData && this._frameData.getFrameByName(value) !== null)
573573
{
574574
this.currentFrame = this._frameData.getFrameByName(value);
575575

0 commit comments

Comments
 (0)