Skip to content

Commit b7ae029

Browse files
committed
No need to use globalAlpha or run fillRect twice.
1 parent 751bfa9 commit b7ae029

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

src/renderer/canvas/CanvasRenderer.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -441,22 +441,20 @@ var CanvasRenderer = new Class({
441441
}
442442

443443
ctx.setTransform(1, 0, 0, 1, 0, 0);
444+
ctx.globalCompositeOperation = 'source-over';
444445

445-
if (camera._fadeAlpha > 0 || camera._flashAlpha > 0)
446+
if (camera._fadeAlpha > 0)
446447
{
447-
ctx.globalCompositeOperation = 'source-over';
448-
449448
// fade rendering
450-
ctx.fillStyle = 'rgb(' + (camera._fadeRed * 255) + ',' + (camera._fadeGreen * 255) + ',' + (camera._fadeBlue * 255) + ')';
451-
ctx.globalAlpha = camera._fadeAlpha;
449+
ctx.fillStyle = 'rgba(' + (camera._fadeRed * 255) + ',' + (camera._fadeGreen * 255) + ',' + (camera._fadeBlue * 255) + ',' + camera._fadeAlpha + ')';
452450
ctx.fillRect(camera.x, camera.y, camera.width, camera.height);
451+
}
453452

453+
if (camera._flashAlpha > 0)
454+
{
454455
// flash rendering
455-
ctx.fillStyle = 'rgb(' + (camera._flashRed * 255) + ',' + (camera._flashGreen * 255) + ',' + (camera._flashBlue * 255) + ')';
456-
ctx.globalAlpha = camera._flashAlpha;
456+
ctx.fillStyle = 'rgba(' + (camera._flashRed * 255) + ',' + (camera._flashGreen * 255) + ',' + (camera._flashBlue * 255) + ',' + camera._flashAlpha + ')';
457457
ctx.fillRect(camera.x, camera.y, camera.width, camera.height);
458-
459-
ctx.globalAlpha = 1.0;
460458
}
461459

462460
// Reset the camera scissor

0 commit comments

Comments
 (0)