Skip to content

Commit c2bf22e

Browse files
committed
Added useCapture flags to removeEventListener where approriate
Event listeners added with true passed in as the useCapture flag are only removed when true is also passed into the removeEventListener call. Adding this flag to the stop method where appropriate fixes a memory leak in IE where events on window are never removed. See https://msdn.microsoft.com/en-us/library/ff975250(v=vs.85).aspx
1 parent 37fc327 commit c2bf22e

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/input/MSPointer.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -428,17 +428,17 @@ Phaser.MSPointer.prototype = {
428428
canvas.removeEventListener('MSPointerDown', this._onMSPointerDown);
429429
canvas.removeEventListener('MSPointerMove', this._onMSPointerMove);
430430
canvas.removeEventListener('MSPointerUp', this._onMSPointerUp);
431-
canvas.removeEventListener('MSPointerOver', this._onMSPointerOver);
432-
canvas.removeEventListener('MSPointerOut', this._onMSPointerOut);
431+
canvas.removeEventListener('MSPointerOver', this._onMSPointerOver, true);
432+
canvas.removeEventListener('MSPointerOut', this._onMSPointerOut, true);
433433

434434
canvas.removeEventListener('pointerdown', this._onMSPointerDown);
435435
canvas.removeEventListener('pointermove', this._onMSPointerMove);
436436
canvas.removeEventListener('pointerup', this._onMSPointerUp);
437-
canvas.removeEventListener('pointerover', this._onMSPointerOver);
438-
canvas.removeEventListener('pointerout', this._onMSPointerOut);
437+
canvas.removeEventListener('pointerover', this._onMSPointerOver, true);
438+
canvas.removeEventListener('pointerout', this._onMSPointerOut, true);
439439

440-
window.removeEventListener('MSPointerUp', this._onMSPointerUpGlobal);
441-
window.removeEventListener('pointerup', this._onMSPointerUpGlobal);
440+
window.removeEventListener('MSPointerUp', this._onMSPointerUpGlobal, true);
441+
window.removeEventListener('pointerup', this._onMSPointerUpGlobal, true);
442442

443443
}
444444

0 commit comments

Comments
 (0)