Skip to content

Commit d02d653

Browse files
committed
TileSprite was using the Size compontent instead of ComputedSize, meaning its getBounds and displayWidth and displayHeight results were incorrect. Fix phaserjs#3789
1 parent 7aa4665 commit d02d653

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,14 @@
5757
* `SceneManager.run` would ignore scenes that are currently in the queue of scenes pending to be added. This has now been fixed so that the scene is queued to be started once it's ready (thanks @rook2pawn)
5858
* `GameObject.disableInteractive` was toggling input. Every second call would turn the input back on (thanks @TadejZupancic)
5959
* The position of the TilemapLayer wasn't taken into account when culling tiles for the Camera. It's now calculated as part of the cull flow (thanks @Upperfoot)
60+
* Fix extra argument passing in Array.Each (thanks @samme)
61+
* TileSprite was using the Size compontent instead of ComputedSize, meaning its `getBounds` and `displayWidth` and `displayHeight` results were incorrect. Fix #3789 (thanks @jjalonso)
6062

6163
### Examples, Documentation and TypeScript
6264

6365
My thanks to the following for helping with the Phaser 3 Examples, Docs and TypeScript definitions, either by reporting errors, fixing them or helping author the docs:
6466

65-
@DannyT @squilibob @dvdbrink @t1gu1 @cyantree @DrevanTonder
67+
@DannyT @squilibob @dvdbrink @t1gu1 @cyantree @DrevanTonder @mikewesthad
6668

6769
Also, a special mention to @andygroff for his excellent work enhancing the search box on the examples site.
6870

src/gameobjects/tilesprite/TileSprite.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ var TileSpriteRender = require('./TileSpriteRender');
2929
*
3030
* @extends Phaser.GameObjects.Components.Alpha
3131
* @extends Phaser.GameObjects.Components.BlendMode
32+
* @extends Phaser.GameObjects.Components.ComputedSize
3233
* @extends Phaser.GameObjects.Components.Depth
3334
* @extends Phaser.GameObjects.Components.Flip
3435
* @extends Phaser.GameObjects.Components.GetBounds
@@ -37,7 +38,6 @@ var TileSpriteRender = require('./TileSpriteRender');
3738
* @extends Phaser.GameObjects.Components.Pipeline
3839
* @extends Phaser.GameObjects.Components.ScaleMode
3940
* @extends Phaser.GameObjects.Components.ScrollFactor
40-
* @extends Phaser.GameObjects.Components.Size
4141
* @extends Phaser.GameObjects.Components.Texture
4242
* @extends Phaser.GameObjects.Components.Tint
4343
* @extends Phaser.GameObjects.Components.Transform
@@ -58,6 +58,7 @@ var TileSprite = new Class({
5858
Mixins: [
5959
Components.Alpha,
6060
Components.BlendMode,
61+
Components.ComputedSize,
6162
Components.Depth,
6263
Components.Flip,
6364
Components.GetBounds,
@@ -66,7 +67,6 @@ var TileSprite = new Class({
6667
Components.Pipeline,
6768
Components.ScaleMode,
6869
Components.ScrollFactor,
69-
Components.Size,
7070
Components.Texture,
7171
Components.Tint,
7272
Components.Transform,

0 commit comments

Comments
 (0)