Extract pixel from correct location for a framebuffer

photonstorm · photonstorm · commit dfba4ae8176a · 2019-07-14T16:00:35.000+01:00
diff --git a/src/renderer/snapshot/WebGLSnapshot.js b/src/renderer/snapshot/WebGLSnapshot.js
@@ -41,7 +41,9 @@ var WebGLSnapshot = function (sourceCanvas, config)
     {
         var pixel = new Uint8Array(4);
 
-        gl.readPixels(x, bufferHeight - y, 1, 1, gl.RGBA, gl.UNSIGNED_BYTE, pixel);
+        var destY = (isFramebuffer) ? y : bufferHeight - y;
+
+        gl.readPixels(x, destY, 1, 1, gl.RGBA, gl.UNSIGNED_BYTE, pixel);
 
         callback.call(null, new Color(pixel[0], pixel[1], pixel[2], pixel[3] / 255));
     }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,9 @@ var WebGLSnapshot = function (sourceCanvas, config)`
`41`	`41`	`{`
`42`	`42`	`var pixel = new Uint8Array(4);`
`43`	`43`
`44`		`- gl.readPixels(x, bufferHeight - y, 1, 1, gl.RGBA, gl.UNSIGNED_BYTE, pixel);`
	`44`	`+ var destY = (isFramebuffer) ? y : bufferHeight - y;`
	`45`	`+`
	`46`	`+ gl.readPixels(x, destY, 1, 1, gl.RGBA, gl.UNSIGNED_BYTE, pixel);`
`45`	`47`
`46`	`48`	`callback.call(null, new Color(pixel[0], pixel[1], pixel[2], pixel[3] / 255));`
`47`	`49`	`}`