Merge pull request phaserjs#3894 from mikewesthad/fix-collision-end-triggering-multiple-times

photonstorm · web-flow · commit e1f554b11995 · 2018-08-06T11:48:31.000+01:00
Fix `collisionEnd` triggering many times in Phaser's Matter.js copy
diff --git a/src/physics/matter-js/lib/collision/Pairs.js b/src/physics/matter-js/lib/collision/Pairs.js
@@ -94,7 +94,7 @@ var Common = require('../core/Common');
         // deactivate previously active pairs that are now inactive
         for (i = 0; i < pairsList.length; i++) {
             pair = pairsList[i];
-            if (!pair.confirmedActive) {
+            if (pair.isActive && !pair.confirmedActive) {
                 Pair.setActive(pair, false, timestamp);
                 collisionEnd.push(pair);
             }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ var Common = require('../core/Common');`
`94`	`94`	`// deactivate previously active pairs that are now inactive`
`95`	`95`	`for (i = 0; i < pairsList.length; i++) {`
`96`	`96`	`pair = pairsList[i];`
`97`		`- if (!pair.confirmedActive) {`
	`97`	`+ if (pair.isActive && !pair.confirmedActive) {`
`98`	`98`	`Pair.setActive(pair, false, timestamp);`
`99`	`99`	`collisionEnd.push(pair);`
`100`	`100`	`}`