Skip to content

Commit e2ab82c

Browse files
committed
Fix types on Data
1 parent 1933547 commit e2ab82c

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/data/DataManager.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var Class = require('../utils/Class');
1818
* @since 3.0.0
1919
*
2020
* @param {any} parent - [description]
21-
* @param {any} eventEmitter - [description]
21+
* @param {EventEmitter} eventEmitter - [description]
2222
*/
2323
var DataManager = new Class({
2424

@@ -53,7 +53,7 @@ var DataManager = new Class({
5353
* [description]
5454
*
5555
* @name Phaser.Data.DataManager#list
56-
* @type {object}
56+
* @type {Object.<string, any>}
5757
* @default {}
5858
* @since 3.0.0
5959
*/
@@ -126,15 +126,15 @@ var DataManager = new Class({
126126
*
127127
* @param {string} search - [description]
128128
*
129-
* @return {object} [description]
129+
* @return {Object.<string, any>} [description]
130130
*/
131131
query: function (search)
132132
{
133133
var results = {};
134134

135135
for (var key in this.list)
136136
{
137-
if (key.match(search))
137+
if (this.list.hasOwnProperty(key) && key.match(search))
138138
{
139139
results[key] = this.list[key];
140140
}
@@ -228,7 +228,7 @@ var DataManager = new Class({
228228
* @method Phaser.Data.DataManager#merge
229229
* @since 3.0.0
230230
*
231-
* @param {object} data - [description]
231+
* @param {Object.<string, any>} data - [description]
232232
* @param {boolean} overwrite - [description]
233233
*
234234
* @return {Phaser.Data.DataManager} This DataManager object.
@@ -240,7 +240,7 @@ var DataManager = new Class({
240240
// Merge data from another component into this one
241241
for (var key in data)
242242
{
243-
if (overwrite || (!overwrite && !this.has(key)))
243+
if (data.hasOwnProperty(key) && (overwrite || (!overwrite && !this.has(key))))
244244
{
245245
this.list[key] = data[key];
246246
}
@@ -336,7 +336,7 @@ var DataManager = new Class({
336336
*
337337
* @method Phaser.Data.DataManager#reset
338338
* @since 3.0.0
339-
*
339+
*
340340
* @return {Phaser.Data.DataManager} This DataManager object.
341341
*/
342342
reset: function ()

0 commit comments

Comments
 (0)