Skip to content

Commit 0704670

Browse files
committed
Cleanup
1 parent f2cf6be commit 0704670

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

src/priv_io.rs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
use byteorder::ReadBytesExt;
2-
use std::error::Error;
32
use std::io;
43
use std::io::prelude::*;
54
use std::fmt;
@@ -159,34 +158,33 @@ fn open_socket(params: &ConnectParams) -> Result<InternalStream, ConnectError> {
159158
}
160159

161160
pub fn initialize_stream(params: &ConnectParams,
162-
ssl: TlsMode)
161+
tls: TlsMode)
163162
-> Result<Box<TlsStream>, ConnectError> {
164163
let mut socket = Stream(try!(open_socket(params)));
165164

166-
let (ssl_required, negotiator) = match ssl {
165+
let (tls_required, handshaker) = match tls {
167166
TlsMode::None => return Ok(Box::new(socket)),
168-
TlsMode::Prefer(negotiator) => (false, negotiator),
169-
TlsMode::Require(negotiator) => (true, negotiator),
167+
TlsMode::Prefer(handshaker) => (false, handshaker),
168+
TlsMode::Require(handshaker) => (true, handshaker),
170169
};
171170

172171
try!(socket.write_message(&Frontend::SslRequest { code: message::SSL_CODE }));
173172
try!(socket.flush());
174173

175174
if try!(socket.read_u8()) == b'N' {
176-
if ssl_required {
177-
let err: Box<Error + Sync + Send> = "The server does not support SSL".into();
178-
return Err(ConnectError::Ssl(err));
175+
if tls_required {
176+
return Err(ConnectError::Ssl("the server does not support TLS".into()));
179177
} else {
180178
return Ok(Box::new(socket));
181179
}
182180
}
183181

184-
// Postgres doesn't support SSL over unix sockets
185182
let host = match params.target {
186183
ConnectTarget::Tcp(ref host) => host,
184+
// Postgres doesn't support TLS over unix sockets
187185
#[cfg(any(feature = "with-unix_socket", all(unix, feature = "nightly")))]
188186
ConnectTarget::Unix(_) => return Err(ConnectError::Io(::bad_response())),
189187
};
190188

191-
negotiator.tls_handshake(host, socket).map_err(ConnectError::Ssl)
189+
handshaker.tls_handshake(host, socket).map_err(ConnectError::Ssl)
192190
}

0 commit comments

Comments
 (0)