Fix off by one in index impl

Author: sfackler

src/lib.rs

@@ -1521,7 +1521,7 @@ pub trait RowIndex {
 impl RowIndex for uint {
     #[inline]
     fn idx(&self, stmt: &Statement) -> Option<uint> {
-        if *self > stmt.result_desc.len() {
+        if *self >= stmt.result_desc.len() {
             None
         } else {
             Some(*self)

tests/test.rs

@@ -540,6 +540,18 @@ fn test_get_was_null() {
     };
 }
 
+#[test]
+fn test_get_off_by_one() {
+    let conn = or_panic!(Connection::connect("postgres://postgres@localhost", &SslMode::None));
+    let stmt = or_panic!(conn.prepare("SELECT 10::INT as id"));
+    let mut result = or_panic!(stmt.query(&[]));
+
+    match result.next().unwrap().get_opt::<uint, i32>(1) {
+        Err(Error::InvalidColumn) => {}
+        res => panic!("unexpected result {}", res),
+    };
+}
+
 #[test]
 fn test_custom_notice_handler() {
     static mut count: uint = 0;