Shuffle unknown type boxing a bit

Author: sfackler

src/lib.rs

@@ -783,10 +783,10 @@ impl InnerConnection {
             rngsubtype
         };
         let element_type = match elem_oid {
-            Some(oid) => Some(Box::new(try!(self.get_type(oid)))),
+            Some(oid) => Some(try!(self.get_type(oid))),
             None => None,
         };
-        let type_ = Type::Unknown(ugh_privacy::new_unknown(name, oid, element_type));
+        let type_ = Type::Unknown(Box::new(ugh_privacy::new_unknown(name, oid, element_type)));
         self.unknown_types.insert(oid, type_.clone());
         Ok(type_)
     }

src/types/mod.rs

@@ -193,7 +193,7 @@ macro_rules! make_postgres_type {
                 $variant,
             )+
             /// An unknown type
-            Unknown(Unknown),
+            Unknown(Box<Unknown>),
         }
 
         impl fmt::Debug for Type {

src/ugh_privacy.rs

@@ -12,10 +12,10 @@ use error::{SqlState, ErrorPosition, ConnectError, Error};
 pub struct Unknown {
     name: String,
     oid: Oid,
-    element_type: Option<Box<Type>>,
+    element_type: Option<Type>,
 }
 
-pub fn new_unknown(name: String, oid: Oid, element_type: Option<Box<Type>>) -> Unknown {
+pub fn new_unknown(name: String, oid: Oid, element_type: Option<Type>) -> Unknown {
     Unknown {
         name: name,
         oid: oid,
@@ -36,7 +36,7 @@ impl Unknown {
 
     /// If this type is an array or range, the type of its members.
     pub fn element_type(&self) -> Option<&Type> {
-        self.element_type.as_ref().map(|e| &**e)
+        self.element_type.as_ref()
     }
 }