Skip to content

Commit bad3a5e

Browse files
committed
Stop storing query string in statement
The query string isn't as useful here since any error at this stage won't be a syntax issue.
1 parent 498d2e7 commit bad3a5e

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

src/lib.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,6 @@ impl PostgresConnection {
400400

401401
Ok(NormalPostgresStatement {
402402
conn: self,
403-
query: query.to_owned(),
404403
name: stmt_name,
405404
param_types: param_types,
406405
result_desc: result_desc,
@@ -541,7 +540,6 @@ pub trait PostgresStatement {
541540

542541
pub struct NormalPostgresStatement<'self> {
543542
priv conn: &'self PostgresConnection,
544-
priv query: ~str,
545543
priv name: ~str,
546544
priv param_types: ~[PostgresType],
547545
priv result_desc: ~[ResultDescription],
@@ -632,8 +630,7 @@ impl<'self> NormalPostgresStatement<'self> {
632630
-> PostgresResult<'a> {
633631
match self.try_lazy_query(row_limit, params) {
634632
Ok(result) => result,
635-
Err(err) => fail2!("Error executing query:\n{}",
636-
err.pretty_error(self.query))
633+
Err(err) => fail2!("Error executing query:\n{}", err.to_str())
637634
}
638635
}
639636

@@ -675,8 +672,7 @@ impl<'self> PostgresStatement for NormalPostgresStatement<'self> {
675672
fn update(&self, params: &[&ToSql]) -> uint {
676673
match self.try_update(params) {
677674
Ok(count) => count,
678-
Err(err) => fail2!("Error running update\n{}",
679-
err.pretty_error(self.query))
675+
Err(err) => fail2!("Error running update\n{}", err.to_str())
680676
}
681677
}
682678

0 commit comments

Comments
 (0)