Skip to content

Commit fc933a2

Browse files
committed
Stop using stamp files for multi-targets
It breaks dependency tracking
1 parent 492d237 commit fc933a2

3 files changed

Lines changed: 8 additions & 17 deletions

File tree

Makefile.in

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,22 @@ INSTALL_DIR := %PREFIX%
99
###############################################################################
1010
PHF_DIR := submodules/rust-phf
1111
PHF := $(foreach file,$(shell $(MAKE) -s -C $(PHF_DIR) print-targets),$(PHF_DIR)/$(file))
12-
PHF_STAMP := $(BUILDDIR)/phf.stamp
1312
OPENSSL_DIR := submodules/rust-openssl
1413
OPENSSL := $(foreach file,$(shell $(MAKE) -s -C $(OPENSSL_DIR) print-target),$(OPENSSL_DIR)/$(file))
15-
OPENSSL_STAMP := $(BUILDDIR)/openssl.stamp
1614

17-
$(PHF): $(PHF_STAMP)
18-
19-
$(PHF_STAMP): | $(BUILDDIR)
15+
.NOTPARALLEL: $(PHF)
16+
$(PHF): | $(BUILDDIR)
2017
$(MAKE) -C $(PHF_DIR)
21-
touch $(PHF_STAMP)
22-
23-
$(OPENSSL): $(OPENSSL_STAMP)
2418

25-
$(OPENSSL_STAMP): | $(BUILDDIR)
19+
.NOTPARALLEL: $(OPENSSL)
20+
$(OPENSSL): | $(BUILDDIR)
2621
$(MAKE) -C $(OPENSSL_DIR)
27-
touch $(OPENSSL_STAMP)
2822

2923
###############################################################################
3024
# Main targets
3125
###############################################################################
3226
POSTGRES_LIB_FILE := src/lib.rs
3327
POSTGRES_LIB := $(foreach file,$(shell $(RUSTC) --crate-file-name $(POSTGRES_LIB_FILE)),$(BUILDDIR)/$(file))
34-
POSTGRES_STAMP := $(BUILDDIR)/postgres.stamp
3528
POSTGRES_TEST := $(BUILDDIR)/$(shell $(RUSTC) --test --crate-file-name $(POSTGRES_LIB_FILE))
3629

3730
POSTGRES_LIB_DEPS := $(BUILDDIR)/postgres.d
@@ -45,12 +38,10 @@ LINK_ARGS := $(foreach file,$(OPENSSL),-L $(dir $(file))) $(foreach file,$(PHF),
4538
$(BUILDDIR):
4639
mkdir -p $@
4740

48-
$(POSTGRES_LIB): $(POSTGRES_STAMP)
49-
50-
$(POSTGRES_STAMP): $(POSTGRES_LIB_FILE) $(PHF) $(OPENSSL) | $(BUILDDIR)
41+
.NOTPARALLEL: $(POSTGRES_LIB)
42+
$(POSTGRES_LIB): $(POSTGRES_LIB_FILE) $(PHF) $(OPENSSL) | $(BUILDDIR)
5143
$(RUSTC) $(RUSTFLAGS) $(LINK_ARGS) --dep-info $(POSTGRES_LIB_DEPS) \
5244
--out-dir $(@D) $<
53-
touch $(POSTGRES_STAMP)
5445

5546
$(POSTGRES_TEST): $(POSTGRES_LIB_FILE) $(PHF) $(OPENSSL) | $(BUILDDIR)
5647
$(RUSTC) $(RUSTFLAGS) $(LINK_ARGS) --dep-info $(POSTGRES_TEST_DEPS) \

submodules/rust-openssl

Submodule rust-openssl updated from d766671 to 7a294af

submodules/rust-phf

Submodule rust-phf updated from f68b675 to 6dcad9b

0 commit comments

Comments
 (0)