Skip to content

Commit 1191d4a

Browse files
committed
Fixed overflow when triggering results messages
Because of the change made previously to make events global, any time a result message was triggered there would be a stack overflow. This was because we were re-triggering the event locally if it happened on a global level, which would start the loop. This has been fixed so the event is never caught locally, but instead uses the global handler.
1 parent e63c0ce commit 1191d4a

7 files changed

Lines changed: 4 additions & 24 deletions

File tree

dist/js/select2.amd.full.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -524,10 +524,6 @@ define('select2/results',[
524524
});
525525

526526
container.on('results:message', function (params) {
527-
self.trigger('results:message', params);
528-
});
529-
530-
this.on('results:message', function (params) {
531527
self.displayMessage(params);
532528
});
533529

dist/js/select2.amd.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -524,10 +524,6 @@ define('select2/results',[
524524
});
525525

526526
container.on('results:message', function (params) {
527-
self.trigger('results:message', params);
528-
});
529-
530-
this.on('results:message', function (params) {
531527
self.displayMessage(params);
532528
});
533529

dist/js/select2.full.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10059,10 +10059,6 @@ define('select2/results',[
1005910059
});
1006010060

1006110061
container.on('results:message', function (params) {
10062-
self.trigger('results:message', params);
10063-
});
10064-
10065-
this.on('results:message', function (params) {
1006610062
self.displayMessage(params);
1006710063
});
1006810064

dist/js/select2.full.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/select2.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -952,10 +952,6 @@ define('select2/results',[
952952
});
953953

954954
container.on('results:message', function (params) {
955-
self.trigger('results:message', params);
956-
});
957-
958-
this.on('results:message', function (params) {
959955
self.displayMessage(params);
960956
});
961957

dist/js/select2.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/js/select2/results.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -360,10 +360,6 @@ define([
360360
});
361361

362362
container.on('results:message', function (params) {
363-
self.trigger('results:message', params);
364-
});
365-
366-
this.on('results:message', function (params) {
367363
self.displayMessage(params);
368364
});
369365

0 commit comments

Comments
 (0)