Skip to content

Commit d411a0f

Browse files
committed
Fixed default selections for arrays
1 parent e3deb3a commit d411a0f

9 files changed

Lines changed: 22 additions & 26 deletions

File tree

dist/js/select2.amd.full.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,7 +1137,8 @@ define('select2/data/select',[
11371137
data = {
11381138
id: $option.val(),
11391139
text: $option.html(),
1140-
disabled: $option.prop('disabled')
1140+
disabled: $option.prop('disabled'),
1141+
selected: $option.prop('selected')
11411142
};
11421143
} else if ($option.is('optgroup')) {
11431144
data = {
@@ -1244,9 +1245,9 @@ define('select2/data/array',[
12441245
continue;
12451246
}
12461247

1247-
var option = this.option(item);
1248+
var $option = this.option(item);
12481249

1249-
this.$element.append(option);
1250+
this.$element.append($option);
12501251
}
12511252
};
12521253

dist/js/select2.amd.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,7 +1137,8 @@ define('select2/data/select',[
11371137
data = {
11381138
id: $option.val(),
11391139
text: $option.html(),
1140-
disabled: $option.prop('disabled')
1140+
disabled: $option.prop('disabled'),
1141+
selected: $option.prop('selected')
11411142
};
11421143
} else if ($option.is('optgroup')) {
11431144
data = {
@@ -1244,9 +1245,9 @@ define('select2/data/array',[
12441245
continue;
12451246
}
12461247

1247-
var option = this.option(item);
1248+
var $option = this.option(item);
12481249

1249-
this.$element.append(option);
1250+
this.$element.append($option);
12501251
}
12511252
};
12521253

dist/js/select2.full.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10672,7 +10672,8 @@ define('select2/data/select',[
1067210672
data = {
1067310673
id: $option.val(),
1067410674
text: $option.html(),
10675-
disabled: $option.prop('disabled')
10675+
disabled: $option.prop('disabled'),
10676+
selected: $option.prop('selected')
1067610677
};
1067710678
} else if ($option.is('optgroup')) {
1067810679
data = {
@@ -10779,9 +10780,9 @@ define('select2/data/array',[
1077910780
continue;
1078010781
}
1078110782

10782-
var option = this.option(item);
10783+
var $option = this.option(item);
1078310784

10784-
this.$element.append(option);
10785+
this.$element.append($option);
1078510786
}
1078610787
};
1078710788

dist/js/select2.full.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/select2.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1565,7 +1565,8 @@ define('select2/data/select',[
15651565
data = {
15661566
id: $option.val(),
15671567
text: $option.html(),
1568-
disabled: $option.prop('disabled')
1568+
disabled: $option.prop('disabled'),
1569+
selected: $option.prop('selected')
15691570
};
15701571
} else if ($option.is('optgroup')) {
15711572
data = {
@@ -1672,9 +1673,9 @@ define('select2/data/array',[
16721673
continue;
16731674
}
16741675

1675-
var option = this.option(item);
1676+
var $option = this.option(item);
16761677

1677-
this.$element.append(option);
1678+
this.$element.append($option);
16781679
}
16791680
};
16801681

dist/js/select2.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/examples.html

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -473,15 +473,6 @@ <h2>Example code</h2>
473473

474474
var data = [{ id: 0, text: 'enhancement' }, { id: 1, text: 'bug' }, { id: 2, text: 'duplicate' }, { id: 3, text: 'invalid' }, { id: 4, text: 'wontfix' }];
475475

476-
var data = [];
477-
478-
for (var i = 0; i < 9999; i++) {
479-
data.push({
480-
id: i.toString(),
481-
text: i
482-
});
483-
}
484-
485476
var $ajax = $(".js-example-data-ajax");
486477

487478
var $disabledResults = $(".js-example-disabled-results");

src/js/select2/data/array.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ define([
4646
continue;
4747
}
4848

49-
var option = this.option(item);
49+
var $option = this.option(item);
5050

51-
this.$element.append(option);
51+
this.$element.append($option);
5252
}
5353
};
5454

src/js/select2/data/select.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,8 @@ define([
158158
data = {
159159
id: $option.val(),
160160
text: $option.html(),
161-
disabled: $option.prop('disabled')
161+
disabled: $option.prop('disabled'),
162+
selected: $option.prop('selected')
162163
};
163164
} else if ($option.is('optgroup')) {
164165
data = {

0 commit comments

Comments
 (0)