Skip to content

Rename CSS Custom Properties (Variables) #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
klimashkin opened this issue May 10, 2019 · 5 comments
Closed

Rename CSS Custom Properties (Variables) #37

klimashkin opened this issue May 10, 2019 · 5 comments
Assignees

Comments

@klimashkin
Copy link

Hi!
We are dropping IE11 support in our company, so finally we start leveraging CSS Variables natively 🎉 But as classnames they might become pretty wordy, so it would be nice to have an option to mangle them too along with classnames and animation names!

@JPeer264
Copy link
Owner

Hey happy to hear that you are dropping IE11 :) My company is still using it for a while unfortunately. But yeah I agree, CSS Variables support sounds like a good idea. I will investigate in it ;)

@JPeer264 JPeer264 self-assigned this May 10, 2019
@JPeer264
Copy link
Owner

JPeer264 commented May 10, 2019

@klimashkin works in v3.2.1 💪

EDIT:
Seems like something went wrong with my rcs-core build ;) - 3.2.1 it is

@klimashkin
Copy link
Author

Awesome! Is it possible also to have a flag for that, similar to replaceKeyframes? Not always it's needed to be mangled : )

@JPeer264
Copy link
Owner

JPeer264 commented May 10, 2019

Ah whoops seems like that's the only option I forgot to put in the docs 😅 And it seems I have a kind of inconsistency in here, as my option is ignoreCssVariables, so by default it is set to false. I will rename replaceKeyframes in the next major release to ignoreKeyframes and will also set it to false so I have some consitent options if that's ok for you ;)

@klimashkin
Copy link
Author

Yes, that works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants