Skip to content

Commit 9f382c5

Browse files
rdworthrdworth
committed
dialog: changed shadow default to false. Not quite ready to be on by default. Maybe in 1.next.
1 parent 272391b commit 9f382c5

6 files changed

Lines changed: 110 additions & 55 deletions

File tree

‎tests/unit/dialog/dialog.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ var defaults = {
2222
modal: false,
2323
position: 'center',
2424
resizable: true,
25+
shadow: false,
2526
stack: true,
2627
title: '',
2728
width: 300

‎tests/visual/dialog/dialog_option_modal_false.html‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
1-
<!doctype html>
2-
<html lang="en">
3-
<head>
4-
<title>Dialog Visual Test : Dialog option modal false</title>
5-
<link rel="stylesheet" href="../visual.css" type="text/css" />
6-
<link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
7-
<script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
8-
<script type="text/javascript" src="../../../ui/ui.core.js"></script>
9-
<script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
10-
<script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
11-
<script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
12-
<script type="text/javascript">
13-
$(function() {
14-
$("#dialog").dialog({
15-
modal: false
16-
});
17-
});
18-
</script>
19-
</head>
20-
<body>
21-
22-
<div id="dialog" title="Dialog Title">
23-
<p> Dialog Content </p>
24-
</div>
25-
26-
</body>
27-
</html>
1+
<!doctype html>
2+
<html lang="en">
3+
<head>
4+
<title>Dialog Visual Test : Dialog option modal false</title>
5+
<link rel="stylesheet" href="../visual.css" type="text/css" />
6+
<link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
7+
<script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
8+
<script type="text/javascript" src="../../../ui/ui.core.js"></script>
9+
<script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
10+
<script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
11+
<script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
12+
<script type="text/javascript">
13+
$(function() {
14+
$("#dialog").dialog({
15+
modal: false
16+
});
17+
});
18+
</script>
19+
</head>
20+
<body>
21+
22+
<div id="dialog" title="Dialog Title">
23+
<p> Dialog Content </p>
24+
</div>
25+
26+
</body>
27+
</html>

‎tests/visual/dialog/dialog_option_modal_true.html‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
1-
<!doctype html>
2-
<html lang="en">
3-
<head>
4-
<title>Dialog Visual Test : Dialog option modal true</title>
5-
<link rel="stylesheet" href="../visual.css" type="text/css" />
6-
<link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
7-
<script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
8-
<script type="text/javascript" src="../../../ui/ui.core.js"></script>
9-
<script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
10-
<script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
11-
<script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
12-
<script type="text/javascript">
13-
$(function() {
14-
$("#dialog").dialog({
15-
modal: true
16-
});
17-
});
18-
</script>
19-
</head>
20-
<body>
21-
22-
<div id="dialog" title="Dialog Title">
23-
<p> Dialog Content </p>
24-
</div>
25-
26-
</body>
27-
</html>
1+
<!doctype html>
2+
<html lang="en">
3+
<head>
4+
<title>Dialog Visual Test : Dialog option modal true</title>
5+
<link rel="stylesheet" href="../visual.css" type="text/css" />
6+
<link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
7+
<script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
8+
<script type="text/javascript" src="../../../ui/ui.core.js"></script>
9+
<script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
10+
<script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
11+
<script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
12+
<script type="text/javascript">
13+
$(function() {
14+
$("#dialog").dialog({
15+
modal: true
16+
});
17+
});
18+
</script>
19+
</head>
20+
<body>
21+
22+
<div id="dialog" title="Dialog Title">
23+
<p> Dialog Content </p>
24+
</div>
25+
26+
</body>
27+
</html>

‎tests/visual/dialog/dialog_option_shadow_false.html‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<!doctype html>
2+
<html lang="en">
3+
<head>
4+
<title>Dialog Visual Test : Dialog option shadow false</title>
5+
<link rel="stylesheet" href="../visual.css" type="text/css" />
6+
<link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
7+
<script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
8+
<script type="text/javascript" src="../../../ui/ui.core.js"></script>
9+
<script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
10+
<script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
11+
<script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
12+
<script type="text/javascript">
13+
$(function() {
14+
$("#dialog").dialog({
15+
shadow: false
16+
});
17+
});
18+
</script>
19+
</head>
20+
<body>
21+
22+
<div id="dialog" title="Dialog Title">
23+
<p> Dialog Content </p>
24+
</div>
25+
26+
</body>
27+
</html>

‎tests/visual/dialog/dialog_option_shadow_true.html‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<!doctype html>
2+
<html lang="en">
3+
<head>
4+
<title>Dialog Visual Test : Dialog option shadow true</title>
5+
<link rel="stylesheet" href="../visual.css" type="text/css" />
6+
<link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
7+
<script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
8+
<script type="text/javascript" src="../../../ui/ui.core.js"></script>
9+
<script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
10+
<script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
11+
<script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
12+
<script type="text/javascript">
13+
$(function() {
14+
$("#dialog").dialog({
15+
shadow: true
16+
});
17+
});
18+
</script>
19+
</head>
20+
<body>
21+
22+
<div id="dialog" title="Dialog Title">
23+
<p> Dialog Content </p>
24+
</div>
25+
26+
</body>
27+
</html>

‎ui/ui.dialog.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ $.extend($.ui.dialog, {
522522
modal: false,
523523
position: 'center',
524524
resizable: true,
525-
shadow: true,
525+
shadow: false,
526526
stack: true,
527527
title: '',
528528
width: 300,

0 commit comments

Comments
 (0)