Skip to content

Commit df8d64a

Browse files
committed
Dailog: fixed #4254 - Dialog: undocumented dragHelper and resizeHelper options should be removed
1 parent 5b00c21 commit df8d64a

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

ui/ui.dialog.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,20 +293,24 @@ $.widget("ui.dialog", {
293293

294294
_makeDraggable: function() {
295295
var self = this,
296-
options = this.options;
296+
options = this.options,
297+
heightBeforeDrag;
297298

298299
this.uiDialog.draggable({
299300
cancel: '.ui-dialog-content',
300301
helper: options.dragHelper,
301302
handle: '.ui-dialog-titlebar',
302303
containment: 'document',
303304
start: function() {
305+
heightBeforeDrag = options.height;
306+
$(this).height($(this).height()).addClass("ui-dialog-dragging");
304307
(options.dragStart && options.dragStart.apply(self.element[0], arguments));
305308
},
306309
drag: function() {
307310
(options.drag && options.drag.apply(self.element[0], arguments));
308311
},
309312
stop: function() {
313+
$(this).removeClass("ui-dialog-dragging").height(heightBeforeDrag);
310314
(options.dragStop && options.dragStop.apply(self.element[0], arguments));
311315
$.ui.dialog.overlay.resize();
312316
}
@@ -330,13 +334,15 @@ $.widget("ui.dialog", {
330334
minWidth: options.minWidth,
331335
minHeight: options.minHeight,
332336
start: function() {
337+
$(this).addClass("ui-dialog-resizing");
333338
(options.resizeStart && options.resizeStart.apply(self.element[0], arguments));
334339
},
335340
resize: function() {
336341
(options.resize && options.resize.apply(self.element[0], arguments));
337342
},
338343
handles: resizeHandles,
339344
stop: function() {
345+
$(this).removeClass("ui-dialog-resizing");
340346
(options.resizeStop && options.resizeStop.apply(self.element[0], arguments));
341347
$.ui.dialog.overlay.resize();
342348
}

0 commit comments

Comments
 (0)