Skip to content

Commit 823fd60

Browse files
chore: minimum required nodejs version is 8.9.0 (webpack-contrib#948)
BREAKING CHANGE: minimum required nodejs version is 8.9.0
1 parent 9d70b78 commit 823fd60

File tree

5 files changed

+102
-683
lines changed

5 files changed

+102
-683
lines changed

.github/CONTRIBUTING.md

+16
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,22 @@ Migration: see webpack/webpack#5225
131131
132132
```
133133

134+
## Testing Your Pull Request
135+
136+
You may have the need to test your changes in a real-world project or dependent
137+
module. Thankfully, Github provides a means to do this. Add a dependency to the
138+
`package.json` for such a project as follows:
139+
140+
```json
141+
{
142+
"devDependencies": {
143+
"css-loader": "webpack-contrib/css-loader#{id}/head"
144+
}
145+
}
146+
```
147+
148+
Where `{id}` is the # ID of your Pull Request.
149+
134150
## Thanks
135151

136152
For your interest, time, understanding, and for following this simple guide.

azure-pipelines.yml

+3-12
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
pool:
3737
vmImage: ubuntu-16.04
3838
strategy:
39-
maxParallel: 5
39+
maxParallel: 4
4040
matrix:
4141
node-12:
4242
node_version: ^12.0.0
@@ -47,9 +47,6 @@ jobs:
4747
node-8:
4848
node_version: ^8.9.0
4949
webpack_version: latest
50-
node-6:
51-
node_version: ^6.9.0
52-
webpack_version: latest
5350
node-8-canary:
5451
node_version: ^8.9.0
5552
webpack_version: next
@@ -91,7 +88,7 @@ jobs:
9188
pool:
9289
vmImage: macOS-10.14
9390
strategy:
94-
maxParallel: 5
91+
maxParallel: 4
9592
matrix:
9693
node-12:
9794
node_version: ^12.0.0
@@ -102,9 +99,6 @@ jobs:
10299
node-8:
103100
node_version: ^8.9.0
104101
webpack_version: latest
105-
node-6:
106-
node_version: ^6.9.0
107-
webpack_version: latest
108102
node-8-canary:
109103
node_version: ^8.9.0
110104
webpack_version: next
@@ -146,7 +140,7 @@ jobs:
146140
pool:
147141
vmImage: windows-2019
148142
strategy:
149-
maxParallel: 5
143+
maxParallel: 4
150144
matrix:
151145
node-12:
152146
node_version: ^12.0.0
@@ -157,9 +151,6 @@ jobs:
157151
node-8:
158152
node_version: ^8.9.0
159153
webpack_version: latest
160-
node-6:
161-
node_version: ^6.9.0
162-
webpack_version: latest
163154
node-8-canary:
164155
node_version: ^8.9.0
165156
webpack_version: next

babel.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ module.exports = (api) => {
1010
'@babel/preset-env',
1111
{
1212
targets: {
13-
node: '6.9.0',
13+
node: '8.9.0',
1414
},
1515
},
1616
],

0 commit comments

Comments
 (0)