Use go-gh for SSH hostname alias translation (cli#5654)

Author: samcoe

context/remote.go

@@ -89,15 +89,18 @@ func (r Remote) RepoHost() string {
 	return r.Repo.RepoHost()
 }
 
-// TODO: accept an interface instead of git.RemoteSet
-func TranslateRemotes(gitRemotes git.RemoteSet, urlTranslate func(*url.URL) *url.URL) (remotes Remotes) {
+type Translator interface {
+	Translate(*url.URL) *url.URL
+}
+
+func TranslateRemotes(gitRemotes git.RemoteSet, translator Translator) (remotes Remotes) {
 	for _, r := range gitRemotes {
 		var repo ghrepo.Interface
 		if r.FetchURL != nil {
-			repo, _ = ghrepo.FromURL(urlTranslate(r.FetchURL))
+			repo, _ = ghrepo.FromURL(translator.Translate(r.FetchURL))
 		}
 		if r.PushURL != nil && repo == nil {
-			repo, _ = ghrepo.FromURL(urlTranslate(r.PushURL))
+			repo, _ = ghrepo.FromURL(translator.Translate(r.PushURL))
 		}
 		if repo == nil {
 			continue

context/remote_test.go

@@ -28,6 +28,12 @@ func Test_Remotes_FindByName(t *testing.T) {
 	assert.Error(t, err, "no GitHub remotes found")
 }
 
+type identityTranslator struct{}
+
+func (it identityTranslator) Translate(u *url.URL) *url.URL {
+	return u
+}
+
 func Test_translateRemotes(t *testing.T) {
 	publicURL, _ := url.Parse("https://github.com/monalisa/hello")
 	originURL, _ := url.Parse("http://example.com/repo")
@@ -43,10 +49,7 @@ func Test_translateRemotes(t *testing.T) {
 		},
 	}
 
-	identityURL := func(u *url.URL) *url.URL {
-		return u
-	}
-	result := TranslateRemotes(gitRemotes, identityURL)
+	result := TranslateRemotes(gitRemotes, identityTranslator{})
 
 	if len(result) != 1 {
 		t.Errorf("got %d results", len(result))