Now request all issue and review comments from PRs…

Author: sergiou87

app/src/lib/api.ts

@@ -1168,7 +1168,7 @@ export class API {
     }
   }
 
-  /** Fetches all comments from a given pull request. */
+  /** Fetches all review comments from a given pull request. */
   public async fetchPullRequestComments(
     owner: string,
     name: string,
@@ -1187,6 +1187,25 @@ export class API {
     }
   }
 
+  /** Fetches all comments from a given issue. */
+  public async fetchIssueComments(
+    owner: string,
+    name: string,
+    issueNumber: string
+  ) {
+    try {
+      const path = `/repos/${owner}/${name}/issues/${issueNumber}/comments`
+      const response = await this.request('GET', path)
+      return await parsedResponse<IAPIComment[]>(response)
+    } catch (e) {
+      log.debug(
+        `failed fetching issue comments for ${owner}/${name}/issues/${issueNumber}`,
+        e
+      )
+      return []
+    }
+  }
+
   /**
    * Get the combined status for the given ref.
    */

app/src/lib/stores/notifications-debug-store.ts

@@ -76,42 +76,19 @@ export class NotificationsDebugStore {
 
     const ghRepository = repository.gitHubRepository
 
-    const issueComments = await api.fetchPullRequestComments(
+    const issueComments = await api.fetchIssueComments(
       ghRepository.owner.login,
       ghRepository.name,
       pullRequestNumber.toString()
     )
 
-    const issueCommentIds = new Set(issueComments.map(c => c.id))
-
-    // Fetch review comments of type COMMENTED and with no body
-    const allReviews = await api.fetchPullRequestReviews(
+    const reviewComments = await api.fetchPullRequestComments(
       ghRepository.owner.login,
       ghRepository.name,
       pullRequestNumber.toString()
     )
 
-    const commentedReviewsWithNoBody = allReviews.filter(
-      review => review.state === 'COMMENTED' && !review.body
-    )
-
-    const allReviewComments = await Promise.all(
-      commentedReviewsWithNoBody.map(review =>
-        api.fetchPullRequestReviewComments(
-          ghRepository.owner.login,
-          ghRepository.name,
-          pullRequestNumber.toString(),
-          review.id.toString()
-        )
-      )
-    )
-
-    // Only reviews with one comment, and that comment is not an issue comment
-    const singleReviewComments = allReviewComments
-      .flatMap(comments => (comments.length === 1 ? comments : []))
-      .filter(comment => !issueCommentIds.has(comment.id))
-
-    return [...issueComments, ...singleReviewComments]
+    return [...issueComments, ...reviewComments]
   }
 
   /** Simulate a notification for the given pull request review. */