Re-enable appveyor (scalameta#986)

* Re-enable appveyor

* Remove jvmopts.

* Run only tests project.

* Add back jvmopts but without comments.

* Fix file separators in CliTest.

Author: olafurpg

.jvmopts

@@ -5,7 +5,5 @@
 -XX:ReservedCodeCacheSize=250M
 -XX:+TieredCompilation
 -XX:-UseGCOverheadLimit
-# effectively adds GC to Perm space
 -XX:+CMSClassUnloadingEnabled
-# must be enabled for CMSClassUnloadingEnabled to work
 -XX:+UseConcMarkSweepGC

appveyor.yml

@@ -1,17 +1,17 @@
 version: '{build}'
 os: Windows Server 2012
 install:
-  - cmd: choco install sbt -ia "INSTALLDIR=""C:\sbt"""
-  - cmd: SET PATH=C:\sbt\bin;%JAVA_HOME%\bin;%PATH%
-  - cmd: SET SBT_OPTS=-XX:MaxPermSize=2g -Xmx4g
+  - ps: iex (new-object net.webclient).downloadstring('https://get.scoop.sh')
+  - ps: scoop install sbt
 environment:
   CI_SCALA_VERSION: 2.12.2
 build_script:
-  - sbt update
+  - sbt downloadIdea tests/compile
 test_script:
-  - sbt ci-fast ci-sbt-scalafmt
+  - sbt tests/test
 cache:
-  - C:\sbt\ -> appveyor.yml
   - C:\Users\appveyor\.m2
   - C:\Users\appveyor\.ivy2
   - C:\Users\appveyor\.coursier
+  - C:\Users\appveyor\scoop\cache
+  - scalafmt-intellij\idea

readme.md

@@ -9,6 +9,9 @@ Head over to [the user docs][docs] for instructions on how to install scalafmt.
 
 ### Quick help
 
+- `sbt compile` on a clean machine will fail to compile the `scalafmt-intellij` project.
+  - if you plan to develop the intellij plugin, run `downloadIdea` first to fetch the IntelliJ SDK (~600mb).
+  - or, run `sbt test` or `sbt core/compile` (specific project).
 - Run all unit tests: `sbt test`
 - Run only formatting tests: `tests/testOnly *FormatTests`.
 - Write new formatting test: read [this doc](scalafmt-tests/src/test/resources/readme.md).

scalafmt-core/shared/src/main/scala/org/scalafmt/util/OsSpecific.scala

@@ -9,4 +9,8 @@ object OsSpecific {
   def fixSeparatorsInPathPattern(unixSpecificPattern: String): String =
     if (isWindows) unixSpecificPattern.replace("/", """\\""")
     else unixSpecificPattern
+
+  implicit class XtensionStringAsFilename(string: String) {
+    def asFilename: String = fixSeparatorsInPathPattern(string)
+  }
 }

scalafmt-tests/src/test/scala/org/scalafmt/cli/CliTest.scala

@@ -14,6 +14,7 @@ import org.scalafmt.config.Config
 import org.scalafmt.config.ScalafmtConfig
 import org.scalafmt.util.AbsoluteFile
 import org.scalafmt.util.DiffAssertions
+import org.scalafmt.util.OsSpecific._
 import org.scalafmt.util.FileOps
 import org.scalatest.FunSuite
 
@@ -233,7 +234,7 @@ class CliTest extends FunSuite with DiffAssertions {
       Array(
         input.path,
         "--exclude",
-        "target/nested"
+        "target/nested".asFilename
       ))
     Cli.run(options)
     val obtained = dir2string(input)
@@ -242,7 +243,7 @@ class CliTest extends FunSuite with DiffAssertions {
 
   test("scalafmt doesnotexist.scala throws error") {
     def check(filename: String): Unit = {
-      val args = Array(s"$filename.scala")
+      val args = Array(s"$filename.scala".asFilename)
       intercept[FileNotFoundException] {
         Cli.main(args)
       }