Adding in ESLint and fixing basic errors to match #104

Author: jonathanKingston

.eslintignore

@@ -0,0 +1,2 @@
+node_modules
+dist

.eslintrc

@@ -0,0 +1,27 @@
+---
+# babel support more syntax stuff than eslint for now
+#parser: babel-eslint
+
+ecmaFeatures:
+  modules: true
+
+env:
+  es6: true
+  browser: true
+  node: true
+
+# 0: off, 1: warning, 2: error
+rules:
+  # semicolons are useless
+  semi: [2, "never"]
+
+  quotes: [2, "double"]
+
+  # 2 spaces indentation
+  indent: [2, 2]
+
+  # trailing coma are cool for diff
+  comma-dangle: [2, "always-multiline"]
+
+  # enforce comma at eol (never before)
+  comma-style: [2, "last"]

index.js

@@ -1,7 +1,7 @@
 /**
  * Modules dependencies
  */
-var Postcss = require("postcss")
+var postcss = require("postcss")
 var assign = require("object-assign")
 var caniuse = require("caniuse-api")
 
@@ -31,7 +31,7 @@ var caniuseFeaturesMap = {
   // autoprefixer: [null] // will always be null since autoprefixer does the same game as we do
 }
 
-var features = {
+var libraryFeatures = {
   // Reminder: order is important
   customProperties: function(options) { return require("postcss-custom-properties")(options) },
   calc: function(options) { return require("postcss-calc")(options)},
@@ -50,7 +50,7 @@ var features = {
   pseudoClassMatches: function(options) { return require("postcss-selector-matches")(options)},
   pseudoClassNot: function(options) { return require("postcss-selector-not")(options)},
   colorRgba: function(options) { return require("postcss-color-rgba-fallback")(options)},
-  autoprefixer: function(options) { return require("autoprefixer-core")(options).postcss}
+  autoprefixer: function(options) { return require("autoprefixer-core")(options).postcss},
 }
 
 /**
@@ -98,19 +98,19 @@ function cssnext(string, options) {
     if (features.autoprefixer.browsers === undefined) {delete features.autoprefixer.browsers}
   }
 
-  var postcss = Postcss()
+  var postcssInstance = postcss()
 
   // only enable import & url if fs module is available
   var fs = require("fs")
   if (fs && fs.readFile) {
     // @import
     if (options.import !== false) {
-      postcss.use(require("postcss-import")(typeof options.import === "object" ? options.import : undefined))
+      postcssInstance.use(require("postcss-import")(typeof options.import === "object" ? options.import : undefined))
     }
 
     // url() adjustements
     if (options.url !== false) {
-      postcss.use(require("postcss-url")(typeof options.url === "object" ? options.url : undefined))
+      postcssInstance.use(require("postcss-url")(typeof options.url === "object" ? options.url : undefined))
     }
   }
 
@@ -135,19 +135,19 @@ function cssnext(string, options) {
         )
       )
     ) {
-      postcss.use(cssnext.features[key](typeof features[key] === "object" ? features[key] : undefined))
+      postcssInstance.use(cssnext.features[key](typeof features[key] === "object" ? features[key] : undefined))
     }
   })
 
   // minification
   if (options.compress) {
     var csswring = require("csswring")
-    postcss.use(typeof options.compress === "object" ? csswring(options.compress) : csswring)
+    postcssInstance.use(typeof options.compress === "object" ? csswring(options.compress) : csswring)
   }
 
   // classic API if string is passed
   if (typeof string === "string") {
-    var result = postcss.process(string, options)
+    var result = postcssInstance.process(string, options)
 
     // default behavior, cssnext returns a css string if no or inline sourcemap
     if (options.map === null || (options.map === true || options.map.inline)) {
@@ -159,7 +159,7 @@ function cssnext(string, options) {
   }
   // or return the postcss instance that can be consumed as a postcss plugin
   else {
-    return postcss
+    return postcssInstance
   }
 }
 
@@ -168,4 +168,4 @@ function cssnext(string, options) {
  *
  * @type {Object}
  */
-cssnext.features = features
+cssnext.features = libraryFeatures

package.json

@@ -62,6 +62,7 @@
   },
   "devDependencies": {
     "browserify": "^8.1.1",
+    "eslint": "^0.20.0",
     "jscs": "^1.6.2",
     "jshint": "^2.5.6",
     "microtime": "^1.2.0",
@@ -71,7 +72,8 @@
     "standalone": "browserify --standalone cssnext index.js -o dist/cssnext.js",
     "jscs": "jscs .",
     "jshint": "jshint . --exclude-path .gitignore",
-    "pretest": "npm run jscs && npm run jshint && npm run standalone",
+    "eslint": "eslint -f tap .",
+    "pretest": "npm run eslint && npm run jscs && npm run jshint && npm run standalone",
     "test": "tape test/*.js"
   },
   "bin": {

test/cases.js

@@ -29,9 +29,9 @@ test("use case: use plugin options", function(t) {
       {
         features: {
           customProperties: {
-            preserve: true
-          }
-        }
+            preserve: true,
+          },
+        },
       }
     ),
     utils.readFixture("cases/plugin-options.expected"),

test/cli.js

@@ -25,40 +25,40 @@ test("cli", function(t) {
     t.equal(res, output, "should read from a file and write to a file")
     utils.remove("cli.output--io")
   })
-  planned+=1
+  planned += 1
 
   exec(cssnextBin + " test/fixtures/cli.css", function(err, stdout) {
     if (err) { throw err }
     t.equal(stdout, output, "should read from a file and write to stdout")
   })
-  planned+=1
+  planned += 1
 
   var childProcess = exec(cssnextBin, function(err, stdout) {
     if (err) { throw err }
     t.equal(stdout, output, "should read from stdin and write to stdout")
   })
   childProcess.stdin.write(new Buffer(input))
   childProcess.stdin.end()
-  planned+=1
+  planned += 1
 
   exec(cssnextBin + " test/fixtures/cli.dont-exist.css", function(err, stdout, stderr) {
     t.ok(err && err.code === 1, "should return an error when input file is unreadable")
     t.ok(utils.contains(stderr, "Unable to read file"), "should show that the input file is not found")
   })
-  planned+=2
+  planned += 2
 
   exec(cssnextBin + " test/fixtures/cli.error.css", function(err, stdout, stderr) {
     t.ok(err && err.code === 2, "should throw an error")
     t.ok(utils.contains(stderr, "encounters an error"), "should output a readable error")
     t.ok(utils.contains(stderr, "If this error looks like a bug, please report it here"), "should show the url where to report bugs")
   })
-  planned+=3
+  planned += 3
 
   exec(cssnextBin + " --config test/fixtures/config.json test/fixtures/config.css", function(err, stdout) {
     if (err) { throw err }
     t.equal(stdout, utils.readFixture("config.expected"), "should read config file on --config")
   })
-  planned+=1
+  planned += 1
 
   var noCustomPropInput = ":root{--foo:bar}baz{qux:var(--foo)}"
   var childProcessBrowsers = exec(cssnextBin + " --browsers \"Firefox >= 31\"", function(err, stdout) {
@@ -67,64 +67,64 @@ test("cli", function(t) {
   })
   childProcessBrowsers.stdin.write(new Buffer(noCustomPropInput))
   childProcessBrowsers.stdin.end()
-  planned+=1
+  planned += 1
 
   exec(cssnextBin + " --verbose test/fixtures/cli.css test/fixtures/cli.output--verbose.css", function(err, stdout) {
     if (err) { throw err }
     t.ok(utils.contains(stdout, "Output written"), "should log on --verbose")
     utils.remove("cli.output--verbose")
   })
-  planned+=1
+  planned += 1
 
   exec(cssnextBin + " --no-import test/fixtures/import.css", function(err, stdout) {
     if (err) { throw err }
     t.equal(stdout, utils.readFixture("import"), "should not import on --no-import")
   })
-  planned+=1
+  planned += 1
 
   exec(cssnextBin + " --no-url test/fixtures/url.css", {cwd: process.cwd()}, function(err, stdout) {
     if (err) { throw err }
     t.equal(stdout, utils.readFixture("url/dep"), "should not adjust url on --no-url")
   })
-  planned+=1
+  planned += 1
 
   exec(cssnextBin + " --compress test/fixtures/compress.css", function(err, stdout) {
     if (err) { throw err }
     t.equal(stdout, utils.readFixture("compress.default.expected").trim(), "should compress on --compress")
   })
-  planned+=1
+  planned += 1
 
   exec(cssnextBin + " --sourcemap test/fixtures/sourcemap.css", function(err, stdout) {
     if (err) { throw err }
     t.equal(stdout, utils.readFixture("sourcemap.expected").trim(), "should add sourcemap on --sourcemap")
   })
-  planned+=1
+  planned += 1
 
   var toSpace = require("to-space-case")
   var toSlug = require("to-slug-case")
   var features = Object.keys(cssnext.features)
   var no = "--no-" + features.map(function(feature) { return toSlug(feature)}).join(" --no-")
   features.forEach(function(feature) {
     var slug = toSlug(feature)
-    var output = utils.readFixture("features/" + slug)
+    var featureOutput = utils.readFixture("features/" + slug)
     exec(cssnextBin + " " + no + " test/fixtures/features/" + slug + ".css", function(err, stdout) {
       if (err) { throw err }
-      t.equal(stdout, output, "should not modify input of '" + toSpace(feature) + "' fixture if all features are disabled")
+      t.equal(stdout, featureOutput, "should not modify input of '" + toSpace(feature) + "' fixture if all features are disabled")
     })
   })
-  planned+=features.length
+  planned += features.length
 
   exec(cssnextBin + " --watch", function(err, stdout, stderr) {
     t.ok(err && err.code === 3, "should return an error when <input> or <output> are missing when `--watch` option passed")
     t.ok(utils.contains(stderr, "--watch option need"), "should show an explanation when <input> or <output> are missing when `--watch` option passed")
   })
-  planned+=2
+  planned += 2
 
   exec(cssnextBin + " --watch test/fixtures/cli.css", function(err, stdout, stderr) {
     t.ok(err && err.code === 3, "should return an error when <output> is missing when `--watch` option passed")
     t.ok(utils.contains(stderr, "--watch option need"), "should show an explanation when <output> is missing when `--watch` option passed")
   })
-  planned+=2
+  planned += 2
 
   t.plan(planned)
 })