Add PMD check to default Maven goal

Author: garydgregory

pom.xml

@@ -94,7 +94,7 @@
     <commons.jacoco.complexityRatio>0.94</commons.jacoco.complexityRatio>
   </properties>
   <build>
-    <defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check spotbugs:check javadoc:javadoc</defaultGoal>
+    <defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check spotbugs:check pmd:check javadoc:javadoc</defaultGoal>
     <pluginManagement>
       <plugins>
         <plugin>

src/changes/changes.xml

@@ -25,6 +25,7 @@
     <release version="1.8.0" date="YYYY-MM-DD" description="This release contains new features and bug fixes and requires Java 8 or above.">
       <!-- ADD -->
       <action type="add" issue="CLI-332" dev="ggregory" due-to="Claude Warren, Gary Gregory">Add optional HelpFormatter Function to document Deprecated options #271.</action>
+      <action type="add" dev="ggregory" due-to="Gary Gregory">Add PMD check to default Maven goal.</action>
       <!-- FIX -->
       <action type="fix" issue="CLI-331" dev="ggregory" due-to="Claude Warren, Gary Gregory">Handle reporting of deprecated options when parameters are not String type. #270.</action>
       <action type="fix" dev="ggregory" due-to="Claude Warren, Gary Gregory">Avoid throwing NullPointerException when calling CommandLineParser will null array elements.</action>

src/main/java/org/apache/commons/cli/CommandLine.java

@@ -17,8 +17,6 @@ Licensed to the Apache Software Foundation (ASF) under one or more
 
 package org.apache.commons.cli;
 
-import static org.apache.commons.cli.Util.EMPTY_STRING_ARRAY;
-
 import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Iterator;
@@ -414,7 +412,7 @@ public String[] getOptionValues(final Option option) {
                 values.addAll(processedOption.getValuesList());
             }
         }
-        return values.isEmpty() ? null : values.toArray(EMPTY_STRING_ARRAY);
+        return values.isEmpty() ? null : values.toArray(Util.EMPTY_STRING_ARRAY);
     }
 
     /**