Skip to content

Commit 0b6cca9

Browse files
committed
Changes suggested in code review
1 parent 34ca3e9 commit 0b6cca9

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

src/Value/CSSFunction.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ class CSSFunction extends ValueList
2626
/**
2727
* @param non-empty-string $name
2828
* @param RuleValueList|array<Value|string> $arguments
29+
* @param non-empty-string $separator
2930
* @param int<0, max> $lineNumber
3031
*/
3132
public function __construct(string $name, $arguments, string $separator = ',', int $lineNumber = 0)

src/Value/RuleValueList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
class RuleValueList extends ValueList
1313
{
1414
/**
15-
* @param string $separator
15+
* @param non-empty-string $separator
1616
* @param int<0, max> $lineNumber
1717
*/
1818
public function __construct($separator = ',', int $lineNumber = 0)

src/Value/ValueList.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ abstract class ValueList extends Value
2222
protected $components;
2323

2424
/**
25-
* @var string
25+
* @var non-empty-string
2626
*
2727
* @internal since 8.8.0
2828
*/
2929
protected $separator;
3030

3131
/**
3232
* @param array<Value|string>|Value|string $components
33-
* @param string $separator
33+
* @param non-empty-string $separator
3434
* @param int<0, max> $lineNumber
3535
*/
3636
public function __construct($components = [], $separator = ',', int $lineNumber = 0)
@@ -67,11 +67,17 @@ public function setListComponents(array $components): void
6767
$this->components = $components;
6868
}
6969

70+
/**
71+
* @return non-empty-string
72+
*/
7073
public function getListSeparator(): string
7174
{
7275
return $this->separator;
7376
}
7477

78+
/**
79+
* @param non-empty-string $separator
80+
*/
7581
public function setListSeparator(string $separator): void
7682
{
7783
$this->separator = $separator;

0 commit comments

Comments
 (0)