[TASK] Drop redundant constructor code (#932)

- use default values for properties instead of setting them in
  the constructor
- drop constructors that are redundant to the constructor of the
  parent class

Author: oliverklee

src/CSSList/CSSBlockList.php

@@ -20,14 +20,6 @@
  */
 abstract class CSSBlockList extends CSSList
 {
-    /**
-     * @param int<0, max> $lineNumber
-     */
-    public function __construct($lineNumber = 0)
-    {
-        parent::__construct($lineNumber);
-    }
-
     /**
      * @param array<int, DeclarationBlock> $result
      */

src/CSSList/CSSList.php

@@ -38,14 +38,14 @@ abstract class CSSList implements Renderable, Commentable
      *
      * @internal since 8.8.0
      */
-    protected $comments;
+    protected $comments = [];
 
     /**
      * @var array<int, RuleSet|CSSList|Import|Charset>
      *
      * @internal since 8.8.0
      */
-    protected $contents;
+    protected $contents = [];
 
     /**
      * @var int<0, max>
@@ -59,8 +59,6 @@ abstract class CSSList implements Renderable, Commentable
      */
     public function __construct($lineNumber = 0)
     {
-        $this->comments = [];
-        $this->contents = [];
         $this->lineNumber = $lineNumber;
     }
 

src/CSSList/Document.php

@@ -18,14 +18,6 @@
  */
 class Document extends CSSBlockList
 {
-    /**
-     * @param int<0, max> $lineNumber
-     */
-    public function __construct($lineNumber = 0)
-    {
-        parent::__construct($lineNumber);
-    }
-
     /**
      * @throws SourceException
      *

src/CSSList/KeyFrame.php

@@ -19,16 +19,6 @@ class KeyFrame extends CSSList implements AtRule
      */
     private $animationName;
 
-    /**
-     * @param int<0, max> $lineNumber
-     */
-    public function __construct($lineNumber = 0)
-    {
-        parent::__construct($lineNumber);
-        $this->vendorKeyFrame = null;
-        $this->animationName = null;
-    }
-
     /**
      * @param string $vendorKeyFrame
      */

src/OutputFormat.php

@@ -217,12 +217,12 @@ class OutputFormat
     /**
      * @var OutputFormatter|null
      */
-    private $oFormatter = null;
+    private $oFormatter;
 
     /**
      * @var OutputFormat|null
      */
-    private $oNextLevelFormat = null;
+    private $oNextLevelFormat;
 
     /**
      * @var int

src/Parsing/ParserState.php

@@ -37,7 +37,7 @@ class ParserState
     /**
      * @var int
      */
-    private $iCurrentPosition;
+    private $iCurrentPosition = 0;
 
     /**
      * will only be used if the CSS does not contain an `@charset` declaration
@@ -64,7 +64,6 @@ public function __construct($sText, Settings $oParserSettings, $lineNumber = 1)
     {
         $this->oParserSettings = $oParserSettings;
         $this->sText = $sText;
-        $this->iCurrentPosition = 0;
         $this->lineNumber = $lineNumber;
         $this->setCharset($this->oParserSettings->sDefaultCharset);
     }

src/Property/CSSNamespace.php

@@ -32,7 +32,7 @@ class CSSNamespace implements AtRule
      *
      * @internal since 8.8.0
      */
-    protected $comments;
+    protected $comments = [];
 
     /**
      * @param string $mUrl
@@ -44,7 +44,6 @@ public function __construct($mUrl, $prefix = null, $lineNumber = 0)
         $this->mUrl = $mUrl;
         $this->prefix = $prefix;
         $this->lineNumber = $lineNumber;
-        $this->comments = [];
     }
 
     /**

src/Property/Charset.php

@@ -35,7 +35,7 @@ class Charset implements AtRule
      *
      * @internal since 8.8.0
      */
-    protected $comments;
+    protected $comments = [];
 
     /**
      * @param int<0, max> $lineNumber
@@ -44,7 +44,6 @@ public function __construct(CSSString $oCharset, $lineNumber = 0)
     {
         $this->oCharset = $oCharset;
         $this->lineNumber = $lineNumber;
-        $this->comments = [];
     }
 
     /**

src/Property/Import.php

@@ -35,7 +35,7 @@ class Import implements AtRule
      *
      * @internal since 8.8.0
      */
-    protected $comments;
+    protected $comments = [];
 
     /**
      * @param string $mediaQuery
@@ -46,7 +46,6 @@ public function __construct(URL $location, $mediaQuery, $lineNumber = 0)
         $this->location = $location;
         $this->mediaQuery = $mediaQuery;
         $this->lineNumber = $lineNumber;
-        $this->comments = [];
     }
 
     /**

src/Rule/Rule.php

@@ -34,12 +34,12 @@ class Rule implements Renderable, Commentable
     /**
      * @var bool
      */
-    private $bIsImportant;
+    private $bIsImportant = false;
 
     /**
      * @var array<int, int>
      */
-    private $aIeHack;
+    private $aIeHack = [];
 
     /**
      * @var int
@@ -58,7 +58,7 @@ class Rule implements Renderable, Commentable
      *
      * @internal since 8.8.0
      */
-    protected $comments;
+    protected $comments = [];
 
     /**
      * @param string $sRule
@@ -68,12 +68,8 @@ class Rule implements Renderable, Commentable
     public function __construct($sRule, $lineNumber = 0, $iColNo = 0)
     {
         $this->sRule = $sRule;
-        $this->mValue = null;
-        $this->bIsImportant = false;
-        $this->aIeHack = [];
         $this->lineNumber = $lineNumber;
         $this->iColNo = $iColNo;
-        $this->comments = [];
     }
 
     /**

src/RuleSet/DeclarationBlock.php

@@ -27,16 +27,7 @@ class DeclarationBlock extends RuleSet
     /**
      * @var array<int, Selector|string>
      */
-    private $aSelectors;
-
-    /**
-     * @param int<0, max> $lineNumber
-     */
-    public function __construct($lineNumber = 0)
-    {
-        parent::__construct($lineNumber);
-        $this->aSelectors = [];
-    }
+    private $aSelectors = [];
 
     /**
      * @param CSSList|null $list

src/RuleSet/RuleSet.php

@@ -27,7 +27,7 @@ abstract class RuleSet implements Renderable, Commentable
     /**
      * @var array<string, Rule>
      */
-    private $aRules;
+    private $aRules = [];
 
     /**
      * @var int<0, max>
@@ -41,16 +41,14 @@ abstract class RuleSet implements Renderable, Commentable
      *
      * @internal since 8.8.0
      */
-    protected $comments;
+    protected $comments = [];
 
     /**
      * @param int<0, max> $lineNumber
      */
     public function __construct($lineNumber = 0)
     {
-        $this->aRules = [];
         $this->lineNumber = $lineNumber;
-        $this->comments = [];
     }
 
     /**

src/Value/PrimitiveValue.php

@@ -4,13 +4,4 @@
 
 namespace Sabberworm\CSS\Value;
 
-abstract class PrimitiveValue extends Value
-{
-    /**
-     * @param int<0, max> $lineNumber
-     */
-    public function __construct($lineNumber = 0)
-    {
-        parent::__construct($lineNumber);
-    }
-}
+abstract class PrimitiveValue extends Value {}