[BUGFIX] AddRule before sibling with different property name

Part of #974.

Author: JakeQZ

CHANGELOG.md

@@ -105,6 +105,8 @@ Please also have a look at our
 
 ### Fixed
 
+- Insert `Rule` before sibling even with different property name
+  (in `RuleSet::addRule()`) (#1270)
 - Ensure `RuleSet::addRule()` sets non-negative column number when sibling
   provided (#1268)
 - Set line number when `RuleSet::addRule()` called with only column number set

src/RuleSet/RuleSet.php

@@ -104,12 +104,35 @@ public function addRule(Rule $ruleToAdd, ?Rule $sibling = null): void
         $position = \count($this->rules[$propertyName]);
 
         if ($sibling !== null) {
+            $siblingLineNumber = $sibling->getLineNumber();
+            $siblingColumnNumber = $sibling->getColumnNumber();
+            $siblingIsInSet = false;
             $siblingPosition = \array_search($sibling, $this->rules[$propertyName], true);
             if ($siblingPosition !== false) {
+                $siblingIsInSet = true;
                 $position = $siblingPosition;
+            } else {
+                foreach ($this->rules as $rulesForAProperty) {
+                    if (\in_array($sibling, $rulesForAProperty, true)) {
+                        $siblingIsInSet = true;
+                        // Maintain ordering within `$this->rules[$propertyName]`
+                        // by inserting before first `Rule` with a same-or-later position than the sibling.
+                        foreach ($this->rules[$propertyName] as $index => $rule) {
+                            if (
+                                $rule->getLineNumber() > $siblingLineNumber ||
+                                $rule->getLineNumber() === $siblingLineNumber &&
+                                $rule->getColumnNumber() >= $siblingColumnNumber
+                            ) {
+                                $position = $index;
+                                break;
+                            }
+                        }
+                        break;
+                    }
+                }
+            }
+            if ($siblingIsInSet) {
                 // Increment column number of all existing rules on same line, starting at sibling
-                $siblingLineNumber = $sibling->getLineNumber();
-                $siblingColumnNumber = $sibling->getColumnNumber();
                 foreach ($this->rules as $rulesForAProperty) {
                     foreach ($rulesForAProperty as $rule) {
                         if (
@@ -123,6 +146,7 @@ public function addRule(Rule $ruleToAdd, ?Rule $sibling = null): void
                 $ruleToAdd->setPosition($siblingLineNumber, $siblingColumnNumber);
             }
         }
+
         if ($ruleToAdd->getLineNumber() === null) {
             //this node is added manually, give it the next best line
             $columnNumber = $ruleToAdd->getColumnNumber() ?? 0;

tests/Unit/RuleSet/RuleSetTest.php

@@ -221,8 +221,6 @@ public function addRuleWithSiblingInsertsRuleBeforeSibling(
         int $siblingIndex,
         string $propertyNameToAdd
     ): void {
-        self::markTestSkipped('tofix: if property names don\'t match, sibling is ignored');
-
         $ruleToAdd = new Rule($propertyNameToAdd);
         $this->setRulesFromPropertyNames($initialPropertyNames);
         $sibling = $this->subject->getRules()[$siblingIndex];