Skip to content

Commit d38a87f

Browse files
committed
[TASK] Drop atRuleArgs() from the AtRule interface
The classes implementing this interface use a wide variaty of inconsistent return types when they implement this method. This is a hard blocker for introducing native return type declaration for this method.
1 parent 6e9d010 commit d38a87f

File tree

3 files changed

+1
-17
lines changed

3 files changed

+1
-17
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ Please also have a look at our
4646

4747
### Removed
4848

49+
- Drop `atRuleArgs()` from the `AtRule` interface (#1141)
4950
- Remove `OutputFormat::get()` and `::set()` (#1108, #1110)
5051
- Drop special support for vendor prefixes (#1083)
5152
- Remove the IE hack in `Rule` (#995)

config/phpstan-baseline.neon

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,6 @@ parameters:
126126
count: 1
127127
path: ../src/Property/CSSNamespace.php
128128

129-
-
130-
message: '#^Return type \(array\<int, string\>\) of method Sabberworm\\CSS\\Property\\CSSNamespace\:\:atRuleArgs\(\) should be compatible with return type \(string\|null\) of method Sabberworm\\CSS\\Property\\AtRule\:\:atRuleArgs\(\)$#'
131-
identifier: method.childReturnType
132-
count: 1
133-
path: ../src/Property/CSSNamespace.php
134-
135129
-
136130
message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:comments\(\)\.$#'
137131
identifier: method.notFound
@@ -156,12 +150,6 @@ parameters:
156150
count: 1
157151
path: ../src/Property/Import.php
158152

159-
-
160-
message: '#^Return type \(array\<int, Sabberworm\\CSS\\Value\\URL\|string\>\) of method Sabberworm\\CSS\\Property\\Import\:\:atRuleArgs\(\) should be compatible with return type \(string\|null\) of method Sabberworm\\CSS\\Property\\AtRule\:\:atRuleArgs\(\)$#'
161-
identifier: method.childReturnType
162-
count: 1
163-
path: ../src/Property/Import.php
164-
165153
-
166154
message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:comments\(\)\.$#'
167155
identifier: method.notFound

src/Property/AtRule.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,4 @@ interface AtRule extends Renderable, Commentable
3232
* @return string|null
3333
*/
3434
public function atRuleName();
35-
36-
/**
37-
* @return string|null
38-
*/
39-
public function atRuleArgs();
4035
}

0 commit comments

Comments
 (0)