Skip to content

Commit d40fa16

Browse files
committed
[TASK] Drop atRuleArgs() from the AtRule interface
The classes implementing this interface use a wide variaty of inconsistent return types when they implement this method. This is a hard blocker for introducing native return type declaration for this method.
1 parent 46da4b2 commit d40fa16

File tree

3 files changed

+1
-17
lines changed

3 files changed

+1
-17
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ Please also have a look at our
4747

4848
### Removed
4949

50+
- Drop `atRuleArgs()` from the `AtRule` interface (#1141)
5051
- Remove `OutputFormat::get()` and `::set()` (#1108, #1110)
5152
- Drop special support for vendor prefixes (#1083)
5253
- Remove the IE hack in `Rule` (#995)

config/phpstan-baseline.neon

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,6 @@ parameters:
120120
count: 1
121121
path: ../src/Property/CSSNamespace.php
122122

123-
-
124-
message: '#^Return type \(array\<int, string\>\) of method Sabberworm\\CSS\\Property\\CSSNamespace\:\:atRuleArgs\(\) should be compatible with return type \(string\|null\) of method Sabberworm\\CSS\\Property\\AtRule\:\:atRuleArgs\(\)$#'
125-
identifier: method.childReturnType
126-
count: 1
127-
path: ../src/Property/CSSNamespace.php
128-
129123
-
130124
message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:comments\(\)\.$#'
131125
identifier: method.notFound
@@ -150,12 +144,6 @@ parameters:
150144
count: 1
151145
path: ../src/Property/Import.php
152146

153-
-
154-
message: '#^Return type \(array\<int, Sabberworm\\CSS\\Value\\URL\|string\>\) of method Sabberworm\\CSS\\Property\\Import\:\:atRuleArgs\(\) should be compatible with return type \(string\|null\) of method Sabberworm\\CSS\\Property\\AtRule\:\:atRuleArgs\(\)$#'
155-
identifier: method.childReturnType
156-
count: 1
157-
path: ../src/Property/Import.php
158-
159147
-
160148
message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:comments\(\)\.$#'
161149
identifier: method.notFound

src/Property/AtRule.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,4 @@ interface AtRule extends Renderable, Commentable
2323
* @return string|null
2424
*/
2525
public function atRuleName();
26-
27-
/**
28-
* @return string|null
29-
*/
30-
public function atRuleArgs();
3126
}

0 commit comments

Comments
 (0)