Skip to content

Commit e28d0c3

Browse files
committed
Change suggested in review
1 parent 9fb8406 commit e28d0c3

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

tests/Unit/RuleSet/RuleSetTest.php

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -737,13 +737,13 @@ public function removeAllRulesRemovesAllRules(array $propertyNamesToRemove): voi
737737
*
738738
* @dataProvider providePropertyNames
739739
*/
740-
public function setRulesOnVirginSetsRules(array $propertyNamesToSet): void
740+
public function setRulesOnVirginSetsRulesWithoutPositionInOrder(array $propertyNamesToSet): void
741741
{
742742
$rulesToSet = self::createRulesFromPropertyNames($propertyNamesToSet);
743743

744744
$this->subject->setRules($rulesToSet);
745745

746-
self::assertArrayHasSameValues($rulesToSet, $this->subject->getRules());
746+
self::assertSame($rulesToSet, $this->subject->getRules());
747747
}
748748

749749
/**
@@ -769,7 +769,7 @@ public function setRulesReplacesRules(array $initialPropertyNames, array $proper
769769

770770
$this->subject->setRules($rulesToSet);
771771

772-
self::assertArrayHasSameValues($rulesToSet, $this->subject->getRules());
772+
self::assertSame($rulesToSet, $this->subject->getRules());
773773
}
774774

775775
/**
@@ -888,12 +888,4 @@ function (string $propertyName): Rule {
888888
$propertyNames
889889
);
890890
}
891-
892-
private static function assertArrayHasSameValues(array $expected, array $actual, string $message = ''): void
893-
{
894-
self::assertCount(\count($expected), $actual, $message);
895-
foreach ($expected as $expectedElement) {
896-
self::assertContains($expectedElement, $actual, $message);
897-
}
898-
}
899891
}

0 commit comments

Comments
 (0)