Skip to content

Use null for Import::$mediaQuery to indicate absence #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakeQZ opened this issue Mar 16, 2025 · 1 comment
Open

Use null for Import::$mediaQuery to indicate absence #1177

JakeQZ opened this issue Mar 16, 2025 · 1 comment

Comments

@JakeQZ
Copy link
Collaborator

JakeQZ commented Mar 16, 2025

The code currently uses both null and an empty string to indicate there is no media query. It also appears that when it is an empty string, an extra space will be rendered.

We should consistently use one or other, and it's probably cleaner to use null to indicate absence.

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Mar 16, 2025

We could also make the $mediaQuery parameter of the constructor optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant