Clean up `DeclarationBlock::setSelectors()` & friends #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

3 tasks

oliverklee opened this issue Mar 17, 2025 · 0 comments

Open

3 tasks

Clean up `DeclarationBlock::setSelectors()` & friends #1185

oliverklee opened this issue Mar 17, 2025 · 0 comments

Labels

cleanup

Milestone

9.0.0: Drop suppo...

Collaborator

oliverklee commented Mar 17, 2025 •

edited

Loading

cover it with tests
use a local variable instead of $this->selectors for storing temporary values
change $this->selectors to list<Selector>

The text was updated successfully, but these errors were encountered:

oliverklee added the cleanup label

oliverklee added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment