Skip to content

Minimum version of composer-normalize requires PHP 7.4 #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakeQZ opened this issue Mar 25, 2025 · 2 comments
Open

Minimum version of composer-normalize requires PHP 7.4 #1213

JakeQZ opened this issue Mar 25, 2025 · 2 comments
Labels
developer-specific Issues that only affect maintainers, contributors, and people submitting PRs

Comments

@JakeQZ
Copy link
Collaborator

JakeQZ commented Mar 25, 2025

This is a PHIVE-installed pacakage.

We could do one of two things:

  • Reduce the minimum version requirement in phars.xml to allow a version compatible with PHP 7.2;
  • Document in the contribution guidlines that whilst PHP 7.2 and 7.3 can be used to run the unit tests against those versions, they can't be used for the full suite of CI checks.
@JakeQZ JakeQZ added the developer-specific Issues that only affect maintainers, contributors, and people submitting PRs label Mar 25, 2025
@oliverklee
Copy link
Collaborator

Reduce the minimum version requirement in phars.xml to allow a version compatible with PHP 7.2;

This in general is difficult as this would require the corresponding tool to support the full range of PHP versions that we support.

Document in the contribution guidlines that whilst PHP 7.2 and 7.3 can be used to run the unit tests against those versions, they can't be used for the full suite of CI checks.

Either this, or we move it to Composer and use a multi-version dependency (like we already are doing with PHPStan).

In any case, the results of static code analysis might vary depending on the version of PHP that is used to run the tests (even though it would be possible to at least execute the checks). So we need to document this anyway.

I tend to a "move it to Composer and document the caveats" (and also move the other tools to Composer so we can get rid of PHIVE). What do you think?

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Mar 25, 2025

In any case, the results of static code analysis might vary depending on the version of PHP that is used to run the tests (even though it would be possible to at least execute the checks). So we need to document this anyway.

Yes, I found switching to PHP 7.3 required a downgrade of PHPStan from 2.1.2 to 1.12.16, resulting in two additional errors reported, and many other errors not reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-specific Issues that only affect maintainers, contributors, and people submitting PRs
Projects
None yet
Development

No branches or pull requests

2 participants