Skip to content

[TASK] Avoid the deprecated __toString() in tests #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

[TASK] Avoid the deprecated __toString() in tests #1180

merged 1 commit into from
Mar 16, 2025

Conversation

oliverklee
Copy link
Collaborator

Moving some tests to functional tests and splitting them up will come in later changes for #1057.

@oliverklee
[TASK] Avoid the deprecated __toString() in tests
0680620 
Moving some tests to functional tests and splitting them up
will come in later changes for #1057.
@oliverklee oliverklee requested a review from JakeQZ March 16, 2025 20:56
@oliverklee oliverklee self-assigned this Mar 16, 2025
@coveralls
Copy link

Coverage Status

coverage: 55.929% (-0.1%) from 56.036%
when pulling 0680620 on cleanup/tests/no-string-cast
into 4312c56 on main.

@JakeQZ JakeQZ merged commit f9609c4 into main Mar 16, 2025
40 of 41 checks passed
@JakeQZ JakeQZ deleted the cleanup/tests/no-string-cast branch March 16, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ