Skip to content

Commit 242a3ef

Browse files
committed
Improved Contributing Code page and linked to it from Student Expectations page.
1 parent 9d5df3d commit 242a3ef

File tree

2 files changed

+20
-11
lines changed

2 files changed

+20
-11
lines changed

content/contributing-code/contents.lr

+19-11
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,27 @@ body:
1010

1111
Here's a list of [all our current projects](/projects). We do all of our development on GitHub and are generally open to pull requests. We would especially like help with reviving projects that CC's engineering team does not have the time to actively work on (such as [our WordPress plugin](https://github.com/creativecommons/creativecommons-wordpress-plugin) and [license chooser widget](https://github.com/creativecommons/LicenseChooser.js)). We're also looking to improve our documentation and increase our automated test coverage across pretty much all our projects.
1212

13-
We are working on making sure all of our projects are documented, licensed, and have self-contained contribution guidelines. Until we finish that work, follow the checklist below before writing any code.
13+
We are working on making sure all of our projects are documented, licensed, and have self-contained contribution guidelines. Until we finish that work, follow the guidelines below before writing any code.
1414

15-
**Make sure that the project is ready for contribution**
15+
### Check for contribution readiness
1616

17-
If the repository has no license file, code of conduct, or is missing basic documentation, please create a GitHub issue attached to that repository to set those up. We will prioritize adding these files to repositories towards which people show active interest in contributing.
17+
We do not accept contributions to projects without licenses. We're working on adding licenses to all our repositories but we will prioritize ones in which there is an active interest in contribution. If the repository you want to contribute to has no license file (or is missing other infrastructure such as basic documentation), please create a GitHub issue attached to that repository asking us to set those up.
1818

19-
**Make sure your change will be accepted**
19+
### Working on open GitHub issues
2020

21-
* If you want to work on an open GitHub issue tagged "help wanted" or "good first issue", comment on it to indicate that you're working on it (so that no one else does) and submit a pull request when you're ready. No other steps are needed.
22-
* If you want to work on an open GitHub issue without those tags, comment on it to ask if help is desired.
23-
* Indications that it may not be available to work on are that it was created very recently, it already has someone assigned to it, or it is in a project whose name starts with "Active".
24-
* If you want to work on something that there is no GitHub issue for, either create an issue and ask there whether a pull request will be accepted for that change or propose the change in [one of our community forums](/community) before creating the ticket.
25-
* If the project has a roadmap documented in the README, checking the roadmap to see if the feature is already in our pipeline would be a good first step.
21+
We track all our work via the GitHub issues associated with each repository and they are a good way to find things to work on. The first step is to check the labels on the issue and follow the appropriate steps below.
22+
23+
**If the issue is labeled "help wanted" or "good first issue"**, comment on it to indicate that you're working on it (so that no one else does) and submit a pull request when you're ready. No other steps are needed.
24+
* Here's a list of [all issues labeled "good first issue"](https://github.com/search?q=org%3Acreativecommons+is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
25+
* Here's a list of [all issues labeled "help wanted"](https://github.com/search?q=org%3Acreativecommons+is%3Aissue+is%3Aopen+label%3A%22help+wanted%22)
26+
27+
**If it does not have either of those labels**, comment on it to ask if help is desired. If you receive a response that tells you to go ahead and work on it, comment on it to indicate that you're working on it (so that no one else does) and submit a pull request when you're ready.
28+
29+
### Proposing something new
30+
31+
If you want to work on something that there is no GitHub issue for, then propose the change in [one of our community forums](/community) or create a a new GitHub issue associated with the relevant repository amd propose your change there. Be sure to include implementation details and the rationale for the proposed change.
32+
33+
If the project has a roadmap documented in the README, checking the roadmap to see if the feature is already in our pipeline would be a good first step.
2634

2735
When in doubt, ask a question on [one of our community forums](/community).
2836

@@ -36,15 +44,15 @@ In general, we'd like any new projects to use Python, WordPress/PHP, and/or Java
3644

3745
No matter what kind of project you're working on, these are good guidelines to follow
3846

39-
**Code**
47+
### Code
4048

4149
* Write comprehensive and robust tests that cover the changes you've made in your work.
4250
* Follow the appropriate code style standards for the language and framework you're using (e.g. PEP 8 for Python).
4351
* Write readable code – keep functions small and modular and name variables descriptively.
4452
* Document your code thoroughly.
4553
* Make sure all the existing tests pass.
4654

47-
**Pull requests**
55+
### Pull requests
4856

4957
* Use the format specified in pull request template for the repository if there is one.
5058
* Describe your change in detail. Too much detail is better than too little.

content/gsoc-2019/student-expectations/contents.lr

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Here's what we expect of students that Creative Commons is mentoring. If you hav
1313
* Once you've decided on a project, follow our [Application Instructions](/gsoc-2019/application-instructions) to write a draft proposal.
1414
* Get feedback from the primary mentor associated with the project you're proposing before you submit a final application.
1515
* If you're proposing a project that's not on our official ideas list, please talk to our mentors to see if there is anyone interested in mentoring that project before you put any work into the proposal.
16+
* Making a successful contribution to one of our projects will help us get a sense of your work and is highly recommended. Please follow the guidelines in [Contributing Code](/contributing-code) to find issues to work on and submit a successful pull request.
1617

1718
## During the community bonding period
1819

0 commit comments

Comments
 (0)