diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml new file mode 100644 index 0000000..592d72f --- /dev/null +++ b/.github/workflows/release.yml @@ -0,0 +1,59 @@ +on: + push: + # Sequence of patterns matched against refs/tags + tags: + - '3*' + +name: create_release + +jobs: + build: + name: create_release + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v2 + + - name: Slack Notification on Start + uses: rtCamp/action-slack-notify@v2.2.0 + env: + SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_RELEASE }} + SLACK_CHANNEL: notify-nc3-release + SLACK_TITLE: "${{ github.repository }}" + SLACK_COLOR: "#f0ad4e" + SLACK_MESSAGE: "Start Job" + + - name: Create Release + id: create_release + uses: actions/create-release@v1 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token + with: + tag_name: ${{ github.ref }} + release_name: ${{ github.ref }} + body: | + NetCommons ${{ github.ref }} released. + draft: false + prerelease: false + + # テスト成功時はこちらのステップが実行される + - name: Slack Notification on Finish + uses: rtCamp/action-slack-notify@v2.2.0 + if: success() + env: + SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_RELEASE }} + SLACK_CHANNEL: notify-nc3-release + SLACK_TITLE: "${{ github.repository }}" + SLACK_COLOR: good + SLACK_MESSAGE: "Job Success" + + # テスト失敗時はこちらのステップが実行される + - name: Slack Notification on Failure + uses: rtCamp/action-slack-notify@v2.2.0 + if: failure() + env: + SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_RELEASE }} + SLACK_CHANNEL: notify-nc3-tests + SLACK_TITLE: "${{ github.repository }}" + SLACK_COLOR: danger + SLACK_MESSAGE: "Job Failure" diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml new file mode 100644 index 0000000..6da4321 --- /dev/null +++ b/.github/workflows/tests.yml @@ -0,0 +1,168 @@ +on: + push: + branches: + - main + - master + pull_request: + branches: + - main + - master + +name: tests + +jobs: + setup: + name: setup + runs-on: ubuntu-latest + steps: + - name: Slack Notification on Start + uses: rtCamp/action-slack-notify@v2.2.0 + if: env.SLACK_WEBHOOK != '' + env: + SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_TESTS }} + SLACK_CHANNEL: notify-nc3-tests + SLACK_TITLE: "${{ github.repository }}" + SLACK_COLOR: "#f0ad4e" + + tests: + name: tests + needs: setup + runs-on: ubuntu-latest + strategy: + matrix: + php: [ '7.1', '7.2', '7.3', '7.4' ] + mysql: [ '5.7', '8.0' ] + + env: + NC3_BUILD_DIR: "/opt/nc3" + NC3_DOCKER_DIR: "/opt/docker" + NC3_GIT_URL: "git://github.com/NetCommons3/NetCommons3.git" + NC3_GIT_BRANCH: "master" + PLUGIN_BUILD_DIR: ${{ github.workspace }} + PHP_VERSION: ${{ matrix.php }} + MYSQL_VERSION: ${{ matrix.mysql }} + MYSQL_ROOT_PASSWORD: root + MYSQL_DATABASE: cakephp_test + COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + steps: + - uses: actions/checkout@v2 + + - name: Fix up git URLs + run: echo -e '[url "https://github.com/"]\n insteadOf = "git://github.com/"' >> ~/.gitconfig + + - name: environment + run: | + echo "GITHUB_WORKSPACE=${GITHUB_WORKSPACE}" + echo "PLUGIN_BUILD_DIR=${PLUGIN_BUILD_DIR}" + echo "PHP_VERSION=${PHP_VERSION}" + echo "MYSQL_VERSION=${MYSQL_VERSION}" + ls -al ${PLUGIN_BUILD_DIR} + + - name: docker-compose install + run: | + curl -L https://github.com/docker/compose/releases/download/1.29.2/docker-compose-`uname -s`-`uname -m` > ~/docker-compose + chmod +x ~/docker-compose + sudo mv ~/docker-compose /usr/local/bin/docker-compose + docker-compose --version + + - name: git clone nc3 + run: git clone -b ${NC3_GIT_BRANCH} ${NC3_GIT_URL} ${NC3_BUILD_DIR} + + - name: git clone nc3_docker + run: git clone https://github.com/NetCommons3/nc3app-docker.git ${NC3_DOCKER_DIR} + + - name: docker-compose start + run: | + cd ${NC3_DOCKER_DIR} + docker-compose up -d + docker-compose start + + - run: docker ps + + - name: check libraries + run: | + cd ${NC3_DOCKER_DIR} + docker-compose exec -T nc3app bash /opt/scripts/start-on-docker.sh + + - name: nc3 build + run: | + cd ${NC3_DOCKER_DIR} + docker-compose exec -T nc3app bash /opt/scripts/app-build.sh + + - name: phpcs (PHP CodeSniffer) + if: always() + run: | + cd ${NC3_DOCKER_DIR} + docker-compose exec -T nc3app bash /opt/scripts/phpcs.sh + + - name: phpmd (PHP Mess Detector) + if: always() + run: | + cd ${NC3_DOCKER_DIR} + docker-compose exec -T nc3app bash /opt/scripts/phpmd.sh + + - name: phpcpd (PHP Copy/Paste Detector) + if: always() + run: | + cd ${NC3_DOCKER_DIR} + docker-compose exec -T nc3app bash /opt/scripts/phpcpd.sh + + - name: gjslint (JavaScript Style Check) + if: always() + run: | + cd ${NC3_DOCKER_DIR} + docker-compose exec -T nc3app bash /opt/scripts/gjslint.sh + + - name: phpdoc (PHP Documentor) + if: always() + run: | + cd ${NC3_DOCKER_DIR} + docker-compose exec -T nc3app bash /opt/scripts/phpdoc.sh + + - name: phpunit (PHP UnitTest) + if: always() + run: | + cd ${NC3_DOCKER_DIR} + docker-compose exec -T nc3app bash /opt/scripts/phpunit.sh + sudo -s chmod a+w -R ${NC3_BUILD_DIR}/build + +# - name: push coveralls +# env: +# COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} +# COVERALLS_FLAG_NAME: ${{ matrix.php }} +# run: | +# cd ${NC3_BUILD_DIR} +# ls -la ${NC3_BUILD_DIR} +# vendors/bin/php-coveralls --coverage_clover=build/logs/clover.xml -v + + - name: docker-compose remove + if: always() + run: | + cd ${NC3_DOCKER_DIR} + docker-compose rm -f + + # テスト失敗時はこちらのステップが実行される + - name: Slack Notification on Failure + uses: rtCamp/action-slack-notify@v2.2.0 + if: env.SLACK_WEBHOOK != '' && failure() + env: + SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_TESTS }} + SLACK_CHANNEL: notify-nc3-tests + SLACK_TITLE: "${{ github.repository }}(php${{ matrix.php }}, mysql${{ matrix.mysql }})" + SLACK_COLOR: danger + + teardown: + name: teardown + runs-on: ubuntu-latest + needs: tests + steps: + # テスト成功時はこちらのステップが実行される + - name: Slack Notification on Success + uses: rtCamp/action-slack-notify@v2.2.0 + if: env.SLACK_WEBHOOK != '' && success() + env: + SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_TESTS }} + SLACK_CHANNEL: notify-nc3-tests + SLACK_TITLE: "${{ github.repository }}" + SLACK_COLOR: good diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 62fc34c..0000000 --- a/.travis.yml +++ /dev/null @@ -1,41 +0,0 @@ -language: php - -php: - - 5.4 - - 5.5 - - 5.6 - - 7.0 - - 7.1 - -sudo: required - -env: - matrix: - - NETCOMMONS_VERSION=master DB=mysql - global: - - secure: "yoOlkO87bNGEA/LYMbTJ53AAK+1pxIlgWvaPMvLdDWbGfGxUDU2052U//sM1dQ/2vCpJ2PVm5ol7ZztYbc2+lf0YeKIVk5T4XrNqeAJUpQBwAXtBR9T9XAx1jtC2zUEkEK3HtRTb/ss12TtKkGK0AldtSj14zJrEVtSpYsr/nqsLZtCY8x4ShFd1YgI24wiiQxa/essP+nkK8DxZTRTF/ZNMUslYBgXY32kW5MAWmVhTJER3OKCId9VJUqGlZJHRu25FG2HtwB+NrN1i3frjn8oHkO5xUL6XPbBlFSaT/AyhhsDWfPbY8b/rcauplGWMYWA1pFPxaxYXIgCaBLebLuMKk7VpUK4e46kKF5aKtZZ+fplhJ3U0o3jbewp3NlUCmx4qIacMqhkLEQiD+59ugoXfKzHYa5fhm85gKw1v4JBqjtVztyDMBT2C7dXj8eu/bnx1o3kjMjCbB0ersrsAotxgcSMXQB0EQhBQFOEXsJ8jLhnbfCpQSQxt51vnuzylTkanFryIrUkeA4MewiLfy0J3e9gfuSSMcCYavmqipez4Em13xVv8iWjcJPDJeMQVDCIYoXcOW6MoRjcv1g0Uj2AdArrtjUPqH9cqNHpSTqk/LqrtsZT/GDkVWV1FZ0++kEas24GmYWD+x5ESduuS6Ymz9z5upBvxT4wkE4tCvqc=" - - GIT_COMMITTER_NAME=s-nakajima - - GIT_COMMITTER_EMAIL=nakajimashouhei@gmail.com - - GIT_AUTHOR_NAME=s-nakajima - - GIT_AUTHOR_EMAIL=nakajimashouhei@gmail.com - -before_script: - - export NETCOMMONS_BUILD_DIR=`dirname $TRAVIS_BUILD_DIR`/NetCommons3 - - git clone git://github.com/NetCommons3/NetCommons3 $NETCOMMONS_BUILD_DIR - - cd $NETCOMMONS_BUILD_DIR - - git checkout $NETCOMMONS_VERSION - - travis_wait . tools/build/plugins/cakephp/travis/pre.sh - - . tools/build/plugins/cakephp/travis/environment.sh - -script: - - . tools/build/plugins/cakephp/travis/main.sh - -after_script: - - . tools/build/plugins/cakephp/travis/post.sh - -notifications: - email: - recipients: - - netcommons3@googlegroups.com - on_success: never # default: change - on_failure: always # default: always diff --git a/Controller/UserRoleAddController.php b/Controller/UserRoleAddController.php index a3737c6..507527b 100644 --- a/Controller/UserRoleAddController.php +++ b/Controller/UserRoleAddController.php @@ -126,7 +126,7 @@ public function user_role() { //登録処理 if ($this->UserRole->validateUserRole($this->request->data)) { $this->Session->write('UserRoleAdd', $this->request->data); - $count = $this->PluginsRole->find('count', array( + $count = $this->PluginsRole->cacheFindQuery('count', array( 'recursive' => -1, 'conditions' => array( 'role_key' => $this->request->data['UserRoleSetting']['origin_role_key'] diff --git a/Model/UserAttributesRole.php b/Model/UserAttributesRole.php index 38f8616..b712ca0 100644 --- a/Model/UserAttributesRole.php +++ b/Model/UserAttributesRole.php @@ -45,7 +45,7 @@ class UserAttributesRole extends UserRolesAppModel { * @see Model::save() */ public function beforeValidate($options = array()) { - $this->validate = Hash::merge($this->validate, array( + $this->validate = ValidateMerge::merge($this->validate, array( 'role_key' => array( 'notBlank' => array( 'rule' => array('notBlank'), diff --git a/Model/UserRole.php b/Model/UserRole.php index 13109d8..cbed730 100644 --- a/Model/UserRole.php +++ b/Model/UserRole.php @@ -113,7 +113,7 @@ class UserRole extends Role { * @see Model::save() */ public function beforeValidate($options = array()) { - $this->validate = Hash::merge($this->validate, array( + $this->validate = ValidateMerge::merge($this->validate, array( 'language_id' => array( 'numeric' => array( 'rule' => array('numeric'), diff --git a/Model/UserRoleSetting.php b/Model/UserRoleSetting.php index 970fbd7..0d48999 100644 --- a/Model/UserRoleSetting.php +++ b/Model/UserRoleSetting.php @@ -45,7 +45,7 @@ class UserRoleSetting extends UserRolesAppModel { * @see Model::save() */ public function beforeValidate($options = array()) { - $this->validate = Hash::merge($this->validate, array( + $this->validate = ValidateMerge::merge($this->validate, array( 'role_key' => array( 'notBlank' => array( 'rule' => array('notBlank'), diff --git a/README.md b/README.md index 5a25251..a07d0bf 100644 --- a/README.md +++ b/README.md @@ -1,11 +1,6 @@ UserRoles ============== -UserRoles for NetComomns3 - -[![Build Status](https://api.travis-ci.org/NetCommons3/UserRoles.png?branch=master)](https://travis-ci.org/NetCommons3/UserRoles) -[![Coverage Status](https://coveralls.io/repos/NetCommons3/UserRoles/badge.png?branch=master)](https://coveralls.io/r/NetCommons3/UserRoles?branch=master) - -| dependencies | status | -| ------------- | ------ | -| composer.json | [![Dependency Status](https://www.versioneye.com/user/projects/55cbc577c7d56744d20001a9/badge.png)](https://www.versioneye.com/user/projects/55cbc577c7d56744d20001a9) | +[![Tests Status](https://github.com/NetCommons3/UserRoles/actions/workflows/tests.yml/badge.svg?branch=master)](https://github.com/NetCommons3/UserRoles/actions/workflows/tests.yml) +[![Coverage Status](https://coveralls.io/repos/NetCommons3/UserRoles/badge.svg?branch=master)](https://coveralls.io/r/NetCommons3/UserRoles?branch=master) +[![Stable Version](https://img.shields.io/packagist/v/netcommons/user-roles.svg?label=stable)](https://packagist.org/packages/netcommons/user-roles) diff --git a/Test/Case/View/Elements/UserRoles/EditFormTest.php b/Test/Case/View/Elements/UserRoles/EditFormTest.php index 301888a..13945c7 100644 --- a/Test/Case/View/Elements/UserRoles/EditFormTest.php +++ b/Test/Case/View/Elements/UserRoles/EditFormTest.php @@ -10,6 +10,7 @@ */ App::uses('UserRolesNetCommonsControllerTestCase', 'UserRoles.TestSuite'); +App::uses('TestAuthGeneral', 'AuthGeneral.TestSuite'); /** * View/Elements/UserRoles/edit_formのテスト @@ -38,6 +39,9 @@ public function setUp() { NetCommonsCakeTestCase::loadTestPlugin($this, 'UserRoles', 'TestUserRoles'); //テストコントローラ生成 $this->generateNc('TestUserRoles.TestViewElementsUserRolesEditForm'); + + //ログイン + TestAuthGeneral::login($this); } /** diff --git a/VERSION.txt b/VERSION.txt new file mode 100644 index 0000000..86fb650 --- /dev/null +++ b/VERSION.txt @@ -0,0 +1 @@ +3.3.7 diff --git a/phpunit.xml.dist b/phpunit.xml.dist index a63c07b..5cea060 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -1,5 +1,8 @@ + + + app/Plugin/UserRoles @@ -14,6 +17,6 @@ - +