Merge pull request MyIntervals#195 from NitroPack/fix/infinite_loop_linename

Prevent an infinite loop when parsing invalid grid line names

Author: sabberworm

lib/Sabberworm/CSS/Value/LineName.php

@@ -18,7 +18,11 @@ public static function parse(ParserState $oParserState) {
 			if($oParserState->getSettings()->bLenientParsing) {
 				try {
 					$aNames[] = $oParserState->parseIdentifier();
-				} catch(UnexpectedTokenException $e) {}
+				} catch(UnexpectedTokenException $e) {
+					if (!$oParserState->comes(']')) {
+						throw $e;
+					}
+				}
 			} else {
 				$aNames[] = $oParserState->parseIdentifier();
 			}
@@ -28,8 +32,6 @@ public static function parse(ParserState $oParserState) {
 		return new LineName($aNames, $oParserState->currentLine());
 	}
 
-
-
 	public function __toString() {
 		return $this->render(new \Sabberworm\CSS\OutputFormat());
 	}

tests/Sabberworm/CSS/ParserTest.php

@@ -436,6 +436,12 @@ function testEmptyGridLineNameLenientInFile() {
 		$this->assertSame($sExpected, $oDoc->render());
 	}
 
+	function testInvalidGridLineNameInFile() {
+		$oDoc = $this->parsedStructureForFile('invalid-grid-linename', Settings::create()->withMultibyteSupport(true));
+		$sExpected = "div {}";
+		$this->assertSame($sExpected, $oDoc->render());
+	}
+
 	function testUnmatchedBracesInFile() {
 		$oDoc = $this->parsedStructureForFile('unmatched_braces', Settings::create()->withMultibyteSupport(true));
 		$sExpected = 'button, input, checkbox, textarea {outline: 0;margin: 0;}';

tests/files/invalid-grid-linename.css

@@ -0,0 +1 @@
+div { grid-template-columns: [ linename 100px; }