Skip to content

Commit 234062c

Browse files
authored
updated unit tests (apache#76)
1 parent 897593c commit 234062c

2 files changed

Lines changed: 21 additions & 1 deletion

File tree

src/changes/changes.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
<action type="add" dev="ggregory" due-to="Alex Nordlund" issue="CLI-282">
6363
TypeHandler should throw ParseException for an unsupported class.
6464
</action>
65-
<action type="add" dev="ggregory" due-to="waso, Gary Gregory">
65+
<action type="add" dev="ggregory" due-to="Waldemar Sojka, Gary Gregory">
6666
Added setter for Builder.option #33.
6767
</action>
6868
<!-- UPDATE -->

src/test/java/org/apache/commons/cli/OptionTest.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,26 @@ public void testBuilderInsufficientParams2() {
8181
Option.builder(null).desc("desc").build();
8282
}
8383

84+
@Test(expected = IllegalArgumentException.class)
85+
public void testBuilderInvalidOptionName1() {
86+
Option.builder().option("invalid?");
87+
}
88+
89+
@Test(expected = IllegalArgumentException.class)
90+
public void testBuilderInvalidOptionName2() {
91+
Option.builder().option("invalid@");
92+
}
93+
94+
@Test(expected = IllegalArgumentException.class)
95+
public void testBuilderInvalidOptionName3() {
96+
Option.builder("invalid?");
97+
}
98+
99+
@Test(expected = IllegalArgumentException.class)
100+
public void testBuilderInvalidOptionName4() {
101+
Option.builder("invalid@");
102+
}
103+
84104
@Test
85105
public void testBuilderMethods() {
86106
final char defaultSeparator = (char) 0;

0 commit comments

Comments
 (0)