Fix visibility error on media details view (commons-app#2009)

Author: neslihanturan

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java

@@ -546,7 +546,6 @@ private void checkLocationPermission() {
 
 
     private void updateClosestNearbyCardViewInfo() {
-
         curLatLng = locationManager.getLastLocation();
 
         placesDisposable = Observable.fromCallable(() -> nearbyController

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

@@ -45,6 +45,7 @@
 import fr.free.nrw.commons.MediaWikiImageView;
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.category.CategoryDetailsActivity;
+import fr.free.nrw.commons.contributions.ContributionsFragment;
 import fr.free.nrw.commons.delete.DeleteTask;
 import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
 import fr.free.nrw.commons.location.LatLng;
@@ -204,12 +205,14 @@ public void onGlobalLayout() {
         };
         view.getViewTreeObserver().addOnGlobalLayoutListener(layoutListener);
         locale = getResources().getConfiguration().locale;
+
         return view;
     }
 
     @Override
     public void onResume() {
         super.onResume();
+        ((ContributionsFragment)(getParentFragment().getParentFragment())).nearbyNoificationCardView.setVisibility(View.GONE);
         media = detailProvider.getMediaAtPosition(index);
         if (media == null) {
             // Ask the detail provider to ping us when we're ready

app/src/main/java/fr/free/nrw/commons/nearby/NearbyNoificationCardView.java

@@ -201,9 +201,7 @@ public void onClick(View view) {
      * @param place Closes place where we will get information from
      */
     public void updateContent(boolean isClosestNearbyPlaceFound, Place place) {
-        if (this.getVisibility() == GONE) {
-            return; // If nearby card view is invisible because of preferences, do nothing
-        }
+        Timber.d("Update nearby card notification content");
         cardViewVisibilityState = CardViewVisibilityState.READY;
         permissionRequestButton.setVisibility(GONE);
         contentLayout.setVisibility(VISIBLE);