Refactor against double disposal

Tyrrrz · Tyrrrz · commit 580593698867 · 2026-04-22T17:07:43.000+03:00
diff --git a/YoutubeDownloader/ViewModels/Components/DownloadViewModel.cs b/YoutubeDownloader/ViewModels/Components/DownloadViewModel.cs
@@ -145,14 +145,12 @@ private async Task CopyErrorMessageAsync()
 
     protected override void Dispose(bool disposing)
     {
-        if (disposing)
-        {
-            _eventSubscription.Dispose();
-            _cancellationTokenSource.Dispose();
+        if (_isDisposed)
+            return;
 
-            _isDisposed = true;
-        }
+        _isDisposed = true;
 
-        base.Dispose(disposing);
+        _eventSubscription.Dispose();
+        _cancellationTokenSource.Dispose();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -145,14 +145,12 @@ private async Task CopyErrorMessageAsync()`
`145`	`145`
`146`	`146`	`protected override void Dispose(bool disposing)`
`147`	`147`	`{`
`148`		`- if (disposing)`
`149`		`- {`
`150`		`- _eventSubscription.Dispose();`
`151`		`- _cancellationTokenSource.Dispose();`
	`148`	`+ if (_isDisposed)`
	`149`	`+ return;`
`152`	`150`
`153`		`- _isDisposed = true;`
`154`		`- }`
	`151`	`+ _isDisposed = true;`
`155`	`152`
`156`		`- base.Dispose(disposing);`
	`153`	`+ _eventSubscription.Dispose();`
	`154`	`+ _cancellationTokenSource.Dispose();`
`157`	`155`	`}`
`158`	`156`	`}`