Skip to content

Commit 1a54c58

Browse files
committed
Remove now-unnecessary upgrade of warning to error
1 parent cea16a6 commit 1a54c58

File tree

1 file changed

+2
-27
lines changed

1 file changed

+2
-27
lines changed

phpcs.xml.dist

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
<arg name="parallel" value="75"/>
1818
<arg value="p"/>
1919

20-
<!-- Don't hide tokenizer exceptions -->
21-
<rule ref="Internal.Tokenizer.Exception">
22-
<type>error</type>
23-
</rule>
24-
2520
<!-- Include the whole PEAR standard -->
2621
<rule ref="PEAR">
2722
<exclude name="PEAR.NamingConventions.ValidFunctionName"/>
@@ -77,13 +72,6 @@
7772
<rule ref="PSR12.Files.OpenTag"/>
7873
<rule ref="Zend.Files.ClosingTag"/>
7974

80-
<!-- PEAR uses warnings for inline control structures, so switch back to errors -->
81-
<rule ref="Generic.ControlStructures.InlineControlStructure">
82-
<properties>
83-
<property name="error" value="true"/>
84-
</properties>
85-
</rule>
86-
8775
<!-- We use custom indent rules for arrays -->
8876
<rule ref="Generic.Arrays.ArrayIndent"/>
8977
<rule ref="Squiz.Arrays.ArrayDeclaration.KeyNotAligned">
@@ -112,11 +100,10 @@
112100
</properties>
113101
</rule>
114102

115-
<!-- Have 12 chars padding maximum and always show as errors -->
103+
<!-- Have 12 chars padding maximum -->
116104
<rule ref="Generic.Formatting.MultipleStatementAlignment">
117105
<properties>
118106
<property name="maxPadding" value="12"/>
119-
<property name="error" value="true"/>
120107
</properties>
121108
</rule>
122109

@@ -133,20 +120,8 @@
133120
</properties>
134121
</rule>
135122

136-
<!-- Private methods MUST not be prefixed with an underscore -->
137-
<rule ref="PSR2.Methods.MethodDeclaration.Underscore">
138-
<type>error</type>
139-
</rule>
140-
141-
<!-- Private properties MUST not be prefixed with an underscore -->
142-
<rule ref="PSR2.Classes.PropertyDeclaration.Underscore">
143-
<type>error</type>
144-
</rule>
145-
146123
<!-- Do not allow unreachable code. -->
147-
<rule ref="Squiz.PHP.NonExecutableCode">
148-
<type>error</type>
149-
</rule>
124+
<rule ref="Squiz.PHP.NonExecutableCode"/>
150125

151126
<!-- The testing bootstrap file uses string concats to stop IDEs seeing the class aliases -->
152127
<rule ref="Generic.Strings.UnnecessaryStringConcat">

0 commit comments

Comments
 (0)