Fixed bug #592 : USE statement tokenising can sometimes result in mismatched scopes

Author: gsherwood

CodeSniffer/File.php

@@ -1837,6 +1837,14 @@ private static function _createScopeMap(&$tokens, $tokenizer, $eolChar)
                     echo "\tStart scope map at $i:$type => $content".PHP_EOL;
                 }
 
+                if (isset($tokens[$i]['scope_condition']) === true) {
+                    if (PHP_CODESNIFFER_VERBOSITY > 1) {
+                        echo "\t* already processed, skipping *".PHP_EOL;
+                    }
+
+                    continue;
+                }
+
                 $i = self::_recurseScopeMap(
                     $tokens,
                     $numTokens,

CodeSniffer/Standards/PSR2/Tests/ControlStructures/SwitchDeclarationUnitTest.inc

@@ -88,4 +88,18 @@ switch (true) {
             return null;
         }
 }
-?>
+
+use Vendor\Test\FooBar;
+
+function test()
+{
+    switch ($val) {
+        case 'foo':
+            echo 'foo';
+            break;
+        default:
+            echo 'foo';
+    }
+
+    exit;
+}

CodeSniffer/Standards/PSR2/Tests/ControlStructures/SwitchDeclarationUnitTest.inc.fixed

@@ -88,4 +88,18 @@ switch (true) {
             return null;
         }
 }
-?>
+
+use Vendor\Test\FooBar;
+
+function test()
+{
+    switch ($val) {
+        case 'foo':
+            echo 'foo';
+            break;
+        default:
+            echo 'foo';
+    }
+
+    exit;
+}

package.xml

@@ -33,6 +33,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Added more guard code for syntax errors to various sniffs
   - Squiz CommentedOutCodeSniff is now better at ignoring URLs inside comments
   - Fixed bug #584 : Squiz.Arrays.ArrayDeclaration sniff gives incorrect NoComma error for multiline string values
+  - Fixed bug #592 : USE statement tokenising can sometimes result in mismatched scopes
   - Fixed bug #594 : Tokenizer issue on closure that returns by reference
  </notes>
  <contents>