Skip to content

Commit 243aaf4

Browse files
committed
GH Actions: fix snafu with code coverage
Follow up on commit 755f0bc, which simplified the `custom_ini` setting for the code coverage builds, but did so incorrectly, meaning that code which needs the `short_open_tag=On` setting was no longer being recorded as covered. Fixed now.
1 parent c41a2a6 commit 243aaf4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,8 @@ jobs:
256256
shell: bash
257257
run: |
258258
# Set the "short_open_tag" ini to make sure specific conditions are tested.
259-
if [[ ${{ matrix.custom_ini }} == true && "${{ matrix.php }}" == '5.4' ]]; then
260-
echo 'PHP_INI=, date.timezone=Australia/Sydney, short_open_tag=On, asp_tags=On' >> "$GITHUB_OUTPUT"
259+
if [[ ${{ matrix.custom_ini }} == true && "${{ matrix.php }}" == '7.2' ]]; then
260+
echo 'PHP_INI=, date.timezone=Australia/Sydney, short_open_tag=On' >> "$GITHUB_OUTPUT"
261261
fi
262262
263263
- name: Install PHP

0 commit comments

Comments
 (0)