1
- Contributing
2
- -------------
1
+ # Contributing
3
2
4
3
Thank you for your interest in contributing to PHP_CodeSniffer!
5
4
6
5
7
6
## Table of Contents
8
7
9
8
* [ Reporting Bugs] ( #reporting-bugs )
10
- - [ Reporting Security Issues] ( #reporting-security-issues )
11
- - [ Support/Questions About Using PHP_CodeSniffer] ( #supportquestions-about-using-php_codesniffer )
9
+ * [ Reporting Security Issues] ( #reporting-security-issues )
10
+ * [ Support/Questions About Using PHP_CodeSniffer] ( #supportquestions-about-using-php_codesniffer )
12
11
* [ Contributing Without Writing Code] ( #contributing-without-writing-code )
13
- - [ Bug Triage] ( #bug-triage )
14
- - [ Testing Open Pull Requests] ( #testing-open-pull-requests )
15
- - [ Writing sniff documentation] ( #writing-sniff-documentation )
16
- - [ Other tasks] ( #other-tasks )
12
+ * [ Bug Triage] ( #bug-triage )
13
+ * [ Testing Open Pull Requests] ( #testing-open-pull-requests )
14
+ * [ Writing sniff documentation] ( #writing-sniff-documentation )
15
+ * [ Other tasks] ( #other-tasks )
17
16
* [ Contributing With Code] ( #contributing-with-code )
18
- - [ Requesting/Submitting New Features] ( #requestingsubmitting-new-features )
19
- - [ Getting started] ( #getting-started )
20
- - [ While working on a patch] ( #while-working-on-a-patch )
21
- - [ Writing tests] ( #writing-tests )
22
- - [ Submitting your pull request] ( #submitting-your-pull-request )
17
+ * [ Requesting/Submitting New Features] ( #requestingsubmitting-new-features )
18
+ * [ Getting started] ( #getting-started )
19
+ * [ While working on a patch] ( #while-working-on-a-patch )
20
+ * [ Writing tests] ( #writing-tests )
21
+ * [ Submitting your pull request] ( #submitting-your-pull-request )
23
22
* [ Licensing] ( #licensing )
24
23
25
24
@@ -71,7 +70,7 @@ This includes checking whether the bug is something which should be fixed in **_
71
70
To find bugs which need triage, look for issues and PRs with the
72
71
[ "Status: triage"] ( https://github.com/PHPCSStandards/PHP_CodeSniffer/labels/Status%3A%20triage ) label.
73
72
74
- #### Typical bug triage tasks:
73
+ #### Typical bug triage tasks
75
74
* Verify whether the bug is reproducible with the given information.
76
75
* Ask for additional information if it is not.
77
76
* If you find the issue is reported to the wrong repo, ask the reporter to report it to the correct external standard repo
@@ -95,7 +94,7 @@ To get access to a PHPCS version which includes the patch from a pull request, y
95
94
The PHAR files can be found on the summary page of the test workflow run for the PR.
96
95
If the workflow has not been run (yet), the PHAR artifact may not be available (yet).
97
96
98
- #### Typical test tasks:
97
+ #### Typical test tasks
99
98
* Verify that the patch solves the originally reported problem.
100
99
* Verify that the tests added in the PR fail without the fix and pass with the fix.
101
100
* For a fix for false negatives: verify that the correct error message(s) are thrown by the patched code.
@@ -168,10 +167,11 @@ This is an open invitation for interested parties to gather their thoughts about
168
167
> Kind request: If you don't have something to add to the discussion, but do want to indicate a positive or negative opinion
169
168
> on a topic, please add an emoji on the original post instead of leaving a comment.
170
169
171
- > :bulb : On a subset of these issues - the ones which impact maintainers or integrators -, a list of known interested parties
172
- > will be pinged (cc-ed) to gather their thoughts on the topic.
173
- >
174
- > This list is public and
170
+ On a subset of these issues - the ones which impact maintainers or integrators -, a list of known interested parties
171
+ will be pinged (cc-ed) to gather their thoughts on the topic.
172
+
173
+ > [ !TIP]
174
+ > This cc-list list is public and
175
175
> [ maintained in a markdown file] ( https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/.github/community-cc-list.md ) .
176
176
>
177
177
> To add or remove yourself to/from this list, submit a PR to the repo updating the ` community-cc-list.md ` file.
@@ -256,9 +256,9 @@ For example, for the sniff named `Generic.NamingConventions.ConstructorName`:
256
256
* The sniff lives in the ` src/Standards/Generic/Sniffs/NamingConventions/ ` directory.
257
257
* The tests live in the ` src/Standards/Generic/Tests/NamingConventions/ ` directory.
258
258
* The tests consist of two files:
259
- - ` src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.inc ` which is the test _ case_ file containing
259
+ * ` src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.inc ` which is the test _ case_ file containing
260
260
code for the sniff to analyse.
261
- - ` src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.php ` which is the test file, containing two methods,
261
+ * ` src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.php ` which is the test file, containing two methods,
262
262
` getErrorList() ` and ` getWarningList() ` , which should each return an array with as the keys the line number
263
263
in the test _ case_ file and as the values the number of errors or warnings which are expected on each line.
264
264
Only lines on which errors/warnings are expected need to be included in the lists. All other lines will automatically
@@ -339,7 +339,7 @@ While not strictly required, it is greatly appreciated if you comply with the fo
339
339
340
340
* Prefix the commit short description with a hint as to what code is touched in the commit.
341
341
Example: If you have a bug fix for the ` Squiz.WhiteSpace.OperatorSpacing ` sniff, it is a good idea to prefix
342
- the short description with ` Squiz/OperatorSpacing: ` .
342
+ the short description with ` Squiz/OperatorSpacing: ` .
343
343
Another example: if your PR addresses an issue with the Filter classes, prefix the short description
344
344
with ` Filters: ` or ` Filters/FilterName: ` .
345
345
Doing so will:
0 commit comments