Removed all parse error warnings from sniffs (#990)

* Removed all parse error warnings from sniffs

Ref:
* squizlabs/PHP_CodeSniffer 2455

---------

Co-authored-by: Greg Sherwood <gsherwood@squiz.net>
Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>

Author: jrfnl

src/Standards/Generic/Sniffs/Classes/OpeningBraceSameLineSniff.php

@@ -49,8 +49,7 @@ public function process(File $phpcsFile, $stackPtr)
         $errorData       = [strtolower($tokens[$stackPtr]['content']).' '.$tokens[$scopeIdentifier]['content']];
 
         if (isset($tokens[$stackPtr]['scope_opener']) === false) {
-            $error = 'Possible parse error: %s missing opening or closing brace';
-            $phpcsFile->addWarning($error, $stackPtr, 'MissingBrace', $errorData);
+            // Parse error or live coding.
             return;
         }
 

src/Standards/Generic/Tests/Classes/OpeningBraceSameLineUnitTest.inc

@@ -47,7 +47,7 @@ class Test_Class_Bad_H extends Test_Class_Bad_G			{
 class Test_Class_Bad_I implements Test_Interface_Bad_C{
 }
 
-// This one should be flagged as a potential parse error.
+// This one should be ignored as a potential parse error.
 class Test_Class_Bad_H
 
 // This is OK.

src/Standards/Generic/Tests/Classes/OpeningBraceSameLineUnitTest.inc.fixed

@@ -47,7 +47,7 @@ class Test_Class_Bad_H extends Test_Class_Bad_G {
 class Test_Class_Bad_I implements Test_Interface_Bad_C {
 }
 
-// This one should be flagged as a potential parse error.
+// This one should be ignored as a potential parse error.
 class Test_Class_Bad_H
 
 // This is OK.

src/Standards/Generic/Tests/Classes/OpeningBraceSameLineUnitTest.php

@@ -60,7 +60,7 @@ public function getErrorList()
      */
     public function getWarningList()
     {
-        return [51 => 1];
+        return [];
 
     }//end getWarningList()
 

src/Standards/PEAR/Sniffs/Classes/ClassDeclarationSniff.php

@@ -48,8 +48,7 @@ public function process(File $phpcsFile, $stackPtr)
         $errorData = [strtolower($tokens[$stackPtr]['content'])];
 
         if (isset($tokens[$stackPtr]['scope_opener']) === false) {
-            $error = 'Possible parse error: %s missing opening or closing brace';
-            $phpcsFile->addWarning($error, $stackPtr, 'MissingBrace', $errorData);
+            // Parse error or live coding.
             return;
         }
 

src/Standards/PEAR/Tests/Classes/ClassDeclarationUnitTest.2.inc

@@ -7,5 +7,5 @@ if (!class_exists('ClassOpeningBraceTabIndented')) {
 }
 
 
-// Needs to be last test in the file. Intentional parse error.
+// Needs to be last test in the file. Intentional parse error. Should be ignored.
 class MyParseError extends Exception

src/Standards/PEAR/Tests/Classes/ClassDeclarationUnitTest.php

@@ -88,10 +88,6 @@ public function getErrorList($testFile='')
      */
     public function getWarningList($testFile='')
     {
-        if ($testFile === 'ClassDeclarationUnitTest.2.inc') {
-            return [11 => 1];
-        }
-
         return[];
 
     }//end getWarningList()

src/Standards/Squiz/Sniffs/Classes/ValidClassNameSniff.php

@@ -49,9 +49,7 @@ public function process(File $phpcsFile, $stackPtr)
         $tokens = $phpcsFile->getTokens();
 
         if (isset($tokens[$stackPtr]['scope_opener']) === false) {
-            $error = 'Possible parse error: %s missing opening or closing brace';
-            $data  = [$tokens[$stackPtr]['content']];
-            $phpcsFile->addWarning($error, $stackPtr, 'MissingBrace', $data);
+            // Parse error or live coding.
             return;
         }
 

src/Standards/Squiz/Sniffs/Commenting/ClosingDeclarationCommentSniff.php

@@ -62,8 +62,7 @@ public function process(File $phpcsFile, $stackPtr)
             }
 
             if (isset($tokens[$stackPtr]['scope_closer']) === false) {
-                $error = 'Possible parse error: non-abstract method defined as abstract';
-                $phpcsFile->addWarning($error, $stackPtr, 'Abstract');
+                // Parse error or live coding.
                 return;
             }
 
@@ -80,9 +79,7 @@ public function process(File $phpcsFile, $stackPtr)
         }//end if
 
         if (isset($tokens[$stackPtr]['scope_closer']) === false) {
-            $error = 'Possible parse error: %s missing opening or closing brace';
-            $data  = [$tokens[$stackPtr]['content']];
-            $phpcsFile->addWarning($error, $stackPtr, 'MissingBrace', $data);
+            // Parse error or live coding.
             return;
         }
 

src/Standards/Squiz/Sniffs/ControlStructures/ForEachLoopDeclarationSniff.php

@@ -59,14 +59,12 @@ public function process(File $phpcsFile, $stackPtr)
 
         $openingBracket = $phpcsFile->findNext(T_OPEN_PARENTHESIS, $stackPtr);
         if ($openingBracket === false) {
-            $error = 'Possible parse error: FOREACH has no opening parenthesis';
-            $phpcsFile->addWarning($error, $stackPtr, 'MissingOpenParenthesis');
+            // Parse error or live coding.
             return;
         }
 
         if (isset($tokens[$openingBracket]['parenthesis_closer']) === false) {
-            $error = 'Possible parse error: FOREACH has no closing parenthesis';
-            $phpcsFile->addWarning($error, $stackPtr, 'MissingCloseParenthesis');
+            // Parse error or live coding.
             return;
         }
 
@@ -134,8 +132,7 @@ public function process(File $phpcsFile, $stackPtr)
 
         $asToken = $phpcsFile->findNext(T_AS, $openingBracket);
         if ($asToken === false) {
-            $error = 'Possible parse error: FOREACH has no AS statement';
-            $phpcsFile->addWarning($error, $stackPtr, 'MissingAs');
+            // Parse error or live coding.
             return;
         }