You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GH Actions: safeguard the PR label workflow some more
The `srvaroa/labeler` action runner will use the `labeler.yml` from the repo's default branch by default, which is good from a security perspective, but that means that PRs changing the `labeler.yml` file will not be tested until they have been merged and a _next_ PR is opened.
As the `srvaroa/labeler` action runner will silently fail, this also means that the labeling will stop working without any indication (other than labels no longer being added).
I'd like to prevent getting into that situation (again). The `yamllint` workflow I introduced earlier is already a big step in the right direction.
This commit introduces a second safeguard:
* It adds a second job to the workflow which will only run when the files relevant for the workflow are being changed in a PR.
* In that case, this second job will:
- run with the PR-local version of the `labeler.yml` file;
- run on **_all_** pull request events (except merge), not only when the PR is opened.
- fail the workflow run if any errors are encountered.
This should make sure that this workflow is safeguarded properly and will continuing functioning as intended, even when changes are made to the logic.
Refs:
* srvaroa/labeler#105
0 commit comments