Skip to content

Commit d187215

Browse files
committed
Updated changelog for #625 and PR #669
1 parent 1f69b0a commit d187215

File tree

3 files changed

+9
-39
lines changed

3 files changed

+9
-39
lines changed

CodeSniffer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class PHP_CodeSniffer
7373
*
7474
* @var string
7575
*/
76-
const VERSION = '2.3.4';
76+
const VERSION = '2.3.5';
7777

7878
/**
7979
* Package stability; either stable, beta or alpha.

CodeSniffer/Tokenizers/PHP.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -673,18 +673,17 @@ public function tokenizeString($string, $eolChar='\n')
673673
}//end if
674674

675675
/*
676-
HHVM 3.5 and 3.6 tokenizes a hashbang like #!/usr/bin/php
677-
as T_HASHANG instead of T_INLINE_HTML,so fix that.
676+
HHVM 3.5 and 3.6 tokenizes a hashbang line such as #!/usr/bin/php
677+
as T_HASHANG while PHP proper uses T_INLINE_HTML.
678678
*/
679679

680-
if ($tokenIsArray === true
681-
&& token_name($token[0]) === 'T_HASHBANG'
682-
) {
680+
if ($tokenIsArray === true && token_name($token[0]) === 'T_HASHBANG') {
683681
$finalTokens[$newStackPtr] = array(
684682
'content' => $token[1],
685683
'code' => T_INLINE_HTML,
686684
'type' => 'T_INLINE_HTML',
687685
);
686+
688687
if (PHP_CODESNIFFER_VERBOSITY > 1) {
689688
echo "\t\t* token $stackPtr changed from T_HASHBANG to T_INLINE_HTML".PHP_EOL;
690689
}

package.xml

Lines changed: 4 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -17,46 +17,17 @@ http://pear.php.net/dtd/package-2.0.xsd">
1717
<date>2015-09-09</date>
1818
<time>10:15:00</time>
1919
<version>
20-
<release>2.3.4</release>
21-
<api>2.3.4</api>
20+
<release>2.3.5</release>
21+
<api>2.3.5</api>
2222
</version>
2323
<stability>
2424
<release>stable</release>
2525
<api>stable</api>
2626
</stability>
2727
<license uri="https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt">BSD 3-Clause License</license>
2828
<notes>
29-
- JSON report format now includes the fixable status for each error message and the total number of fixable errors
30-
- Added more guard code for function declarations with syntax errors
31-
- Added tokenizer support for the PHP declare construct
32-
-- Thanks to Andy Blyler for the patch
33-
- Generic UnnecessaryStringConcatSniff can now allow strings concatenated over multiple lines
34-
-- Set the allowMultiline property to TRUE (default is FALSE) in your ruleset.xml file to enable this
35-
-- By default, concat used only for getting around line length limits still generates an error
36-
-- Thanks to Stefan Lenselink for the contribution
37-
- Invalid byte sequences no longer throw iconv_strlen() errors (request #639)
38-
-- Thanks to Willem Stuursma for the patch
39-
- Generic TodoSniff and FixmeSniff are now better at processing strings with invalid characters
40-
- PEAR FunctionCallSignatureSniff now ignores indentation of inline HTML content
41-
- Squiz ControlSignatureSniff now supports control structures with only inline HTML content
42-
- Fixed bug #636 : Some class names cause CSS tokenizer to hang
43-
- Fixed bug #638 : VCS blame reports output error content from the blame commands for files not under VC
44-
- Fixed bug #642 : Method params incorrectly detected when default value uses short array syntax
45-
-- Thanks to Josh Davis for the patch
46-
- Fixed bug #644 : PEAR ScopeClosingBrace sniff does not work with mixed HTML/PHP
47-
- Fixed bug #645 : FunctionSignature and ScopeIndent sniffs don't detect indents correctly when PHP open tag is not on a line by itself
48-
- Fixed bug #648 : Namespace not tokenized correctly when followed by multiple use statements
49-
- Fixed bug #654 : Comments affect indent check for BSDAllman brace style
50-
- Fixed bug #658 : Squiz.Functions.FunctionDeclarationSpacing error for multi-line declarations with required spaces greater than zero
51-
-- Thanks to J.D. Grimes for the patch
52-
- Fixed bug #663 : No space after class name generates: Class name "" is not in camel caps format
53-
- Fixed bug #667 : Scope indent check can go into infinite loop due to some parse errors
54-
- Fixed bug #670 : Endless loop in PSR1 SideEffects sniffer if no semicolon after last statement
55-
-- Thanks to Thomas Jarosch for the patch
56-
- Fixed bug #672 : Call-time pass-by-reference false positive
57-
- Fixed bug #683 : Comments are incorrectly reported by PSR2.ControlStructures.SwitchDeclaration sniff
58-
- Fixed bug #687 : ScopeIndent does not check indent correctly for method prefixes like public and abstract
59-
- Fixed bug #689 : False error on some comments after class closing brace
29+
- Fixed bug #625 : Consider working around T_HASHBANG in HHVM 3.5.x and 3.6.x
30+
-- Thanks to Kunal Mehta for the patch
6031
</notes>
6132
<contents>
6233
<dir name="/">

0 commit comments

Comments
 (0)