Skip to content

Commit df26a1f

Browse files
authored
Merge pull request #367 from rodrigoprimo/changelog-improvements-3-4-0
Add links to all issues in the 3.4.2, 3.4.1 and 3.4.0 sections of the changelog
2 parents aa9a9ac + b928700 commit df26a1f

File tree

1 file changed

+73
-38
lines changed

1 file changed

+73
-38
lines changed

CHANGELOG.md

Lines changed: 73 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1449,16 +1449,26 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
14491449
### Fixed
14501450
- Fixed an issue where the PCRE JIT on PHP 7.3 caused PHPCS to die when using the parallel option
14511451
- PHPCS now disables the PCRE JIT before running
1452-
- Fixed bug #2368 : MySource.PHP.AjaxNullComparison throws error when first function has no doc comment
1453-
- Fixed bug #2414 : Indention false positive in switch/case/if combination
1454-
- Fixed bug #2423 : Squiz.Formatting.OperatorBracket.MissingBrackets error with static
1455-
- Fixed bug #2450 : Indentation false positive when closure containing nested IF conditions used as function argument
1456-
- Fixed bug #2452 : LowercasePHPFunctions sniff failing on "new \File()"
1457-
- Fixed bug #2453 : Squiz.CSS.SemicolonSpacingSniff false positive when style name proceeded by an asterisk
1458-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1459-
- Fixed bug #2464 : Fixer conflict between Generic.WhiteSpace.ScopeIndent and Squiz.WhiteSpace.ScopeClosingBrace when class indented 1 space
1460-
- Fixed bug #2465 : Excluding a sniff by path is not working
1461-
- Fixed bug #2467 : PHP open/close tags inside CSS files are replaced with internal PHPCS token strings when auto fixing
1452+
- Fixed bug [#2368] : MySource.PHP.AjaxNullComparison throws error when first function has no doc comment
1453+
- Fixed bug [#2414] : Indention false positive in switch/case/if combination
1454+
- Fixed bug [#2423] : Squiz.Formatting.OperatorBracket.MissingBrackets error with static
1455+
- Fixed bug [#2450] : Indentation false positive when closure containing nested IF conditions used as function argument
1456+
- Fixed bug [#2452] : LowercasePHPFunctions sniff failing on "new \File()"
1457+
- Fixed bug [#2453] : Squiz.CSS.SemicolonSpacingSniff false positive when style name proceeded by an asterisk
1458+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1459+
- Fixed bug [#2464] : Fixer conflict between Generic.WhiteSpace.ScopeIndent and Squiz.WhiteSpace.ScopeClosingBrace when class indented 1 space
1460+
- Fixed bug [#2465] : Excluding a sniff by path is not working
1461+
- Fixed bug [#2467] : PHP open/close tags inside CSS files are replaced with internal PHPCS token strings when auto fixing
1462+
1463+
[#2368]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2368
1464+
[#2414]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2414
1465+
[#2423]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2423
1466+
[#2450]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2450
1467+
[#2452]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2452
1468+
[#2453]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2453
1469+
[#2464]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2464
1470+
[#2465]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2465
1471+
[#2467]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2467
14621472

14631473
## [3.4.1] - 2019-03-19
14641474
### Changed
@@ -1486,16 +1496,16 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
14861496
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
14871497
- Generic.Files.LineEndings no longer adds superfluous new line at the end of JS and CSS files
14881498
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1489-
- Generic.Formatting.DisallowMultipleStatements no longer tries fix lines containing phpcs:ignore statements
1499+
- Generic.Formatting.DisallowMultipleStatements no longer tries to fix lines containing phpcs:ignore statements
14901500
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
14911501
- Generic.Functions.FunctionCallArgumentSpacing now has improved performance and anonymous class support
14921502
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
14931503
- Generic.WhiteSpace.ScopeIndent now respects changes to the "exact" property using phpcs:set mid-way through a file
1494-
- This allows you change the "exact" rule for only some parts of a file
1504+
- This allows you to change the "exact" rule for only some parts of a file
14951505
- Generic.WhiteSpace.ScopeIndent now disables exact indent checking inside all arrays
14961506
- Previously, this was only done when using long array syntax, but it now works for short array syntax as well
14971507
- PEAR.Classes.ClassDeclaration now has improved handling of PHPCS annotations and tab indents
1498-
- PSR12.Classes.ClassInstantiation has changed it's error code from MissingParenthesis to MissingParentheses
1508+
- PSR12.Classes.ClassInstantiation has changed its error code from MissingParenthesis to MissingParentheses
14991509
- PSR12.Keywords.ShortFormTypeKeywords now ignores all spacing inside type casts during both checking and fixing
15001510
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
15011511
- Squiz.Classes.LowercaseClassKeywords now examines the class keyword for anonymous classes
@@ -1535,16 +1545,24 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
15351545
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
15361546

15371547
### Fixed
1538-
- Fixed bug #2298 : PSR2.Classes.ClassDeclaration allows extended class on new line
1548+
- Fixed bug [#2298] : PSR2.Classes.ClassDeclaration allows extended class on new line
15391549
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
1540-
- Fixed bug #2337 : Generic.WhiteSpace.ScopeIndent incorrect error when multi-line function call starts on same line as open tag
1541-
- Fixed bug #2348 : Cache not invalidated when changing a ruleset included by another
1542-
- Fixed bug #2376 : Using __halt_compiler() breaks Generic.PHP.ForbiddenFunctions unless it's last in the function list
1550+
- Fixed bug [#2337] : Generic.WhiteSpace.ScopeIndent incorrect error when multi-line function call starts on same line as open tag
1551+
- Fixed bug [#2348] : Cache not invalidated when changing a ruleset included by another
1552+
- Fixed bug [#2376] : Using __halt_compiler() breaks Generic.PHP.ForbiddenFunctions unless it's last in the function list
15431553
- Thanks to [Sijun Zhu][@Billz95] for the patch
1544-
- Fixed bug #2393 : The gitmodified filter will infinitely loop when encountering deleted file paths
1554+
- Fixed bug [#2393] : The gitmodified filter will infinitely loop when encountering deleted file paths
15451555
- Thanks to [Lucas Manzke][@lmanzke] for the patch
1546-
- Fixed bug #2396 : Generic.WhiteSpace.ScopeIndent incorrect error when multi-line IF condition mixed with HTML
1547-
- Fixed bug #2431 : Use function/const not tokenized as T_STRING when preceded by comment
1556+
- Fixed bug [#2396] : Generic.WhiteSpace.ScopeIndent incorrect error when multi-line IF condition mixed with HTML
1557+
- Fixed bug [#2431] : Use function/const not tokenized as T_STRING when preceded by comment
1558+
1559+
[#2298]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2298
1560+
[#2337]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2337
1561+
[#2348]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2348
1562+
[#2376]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2376
1563+
[#2393]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2393
1564+
[#2396]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2396
1565+
[#2431]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2431
15481566

15491567
## [3.4.0] - 2018-12-20
15501568
### Deprecated
@@ -1569,7 +1587,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
15691587
- This change also converts '(binary)' from T_STRING_CAST to T_BINARY_CAST
15701588
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the help with this patch
15711589
- Array properties set inside a ruleset.xml file can now extend a previous value instead of always overwriting it
1572-
- e.g., if you include a ruleset that defines forbidden functions, can you now add to that list instead of having to redefine it
1590+
- e.g., if you include a ruleset that defines forbidden functions, can you now add to that list instead of having to redefine it
15731591
- To use this feature, add extends="true" to the property tag
15741592
- e.g., property name="forbiddenFunctionNames" type="array" extend="true"
15751593
- Thanks to [Michael Moravec][@Majkl578] for the patch
@@ -1613,7 +1631,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
16131631
- Squiz.Scope.MethodScope
16141632
- Squiz.Scope.StaticThisUsage
16151633
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1616-
- Generic.CodeAnalysis.UnusedFunctionParameter now only skips functions with empty bodies when the class implements an interface
1634+
- Generic.CodeAnalysis.UnusedFunctionParameter now only skips functions with empty bodies when the class implements an interface
16171635
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
16181636
- Generic.CodeAnalysis.UnusedFunctionParameter now has additional error codes to indicate where unused params were found
16191637
- The new error code prefixes are:
@@ -1686,36 +1704,53 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
16861704
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
16871705

16881706
### Fixed
1689-
- Fixed bug #2109 : Generic.Functions.CallTimePassByReference false positive for bitwise and used in function argument
1690-
- Fixed bug #2165 : Conflict between Squiz.Arrays.ArrayDeclaration and ScopeIndent sniffs when heredoc used in array
1691-
- Fixed bug #2167 : Generic.WhiteSpace.ScopeIndent shows invalid error when scope opener indented inside inline HTML
1692-
- Fixed bug #2178 : Generic.NamingConventions.ConstructorName matches methods in anon classes with same name as containing class
1707+
- Fixed bug [#2109] : Generic.Functions.CallTimePassByReference false positive for bitwise and used in function argument
1708+
- Fixed bug [#2165] : Conflict between Squiz.Arrays.ArrayDeclaration and ScopeIndent sniffs when heredoc used in array
1709+
- Fixed bug [#2167] : Generic.WhiteSpace.ScopeIndent shows invalid error when scope opener indented inside inline HTML
1710+
- Fixed bug [#2178] : Generic.NamingConventions.ConstructorName matches methods in anon classes with same name as containing class
16931711
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1694-
- Fixed bug #2190 : PEAR.Functions.FunctionCallSignature incorrect error when encountering trailing PHPCS annotation
1712+
- Fixed bug [#2190] : PEAR.Functions.FunctionCallSignature incorrect error when encountering trailing PHPCS annotation
16951713
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1696-
- Fixed bug #2194 : Generic.Whitespace.LanguageConstructSpacing should not be checking namespace operators
1714+
- Fixed bug [#2194] : Generic.Whitespace.LanguageConstructSpacing should not be checking namespace operators
16971715
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1698-
- Fixed bug #2202 : Squiz.WhiteSpace.OperatorSpacing throws error for negative index when using curly braces for string access
1716+
- Fixed bug [#2202] : Squiz.WhiteSpace.OperatorSpacing throws error for negative index when using curly braces for string access
16991717
- Same issue fixed in Squiz.Formatting.OperatorBracket
17001718
- Thanks to [Andreas Buchenrieder][@anbuc] for the patch
1701-
- Fixed bug #2210 : Generic.NamingConventions.CamelCapsFunctionName not ignoring SoapClient __getCookies() method
1719+
- Fixed bug [#2210] : Generic.NamingConventions.CamelCapsFunctionName not ignoring SoapClient __getCookies() method
17021720
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1703-
- Fixed bug #2211 : PSR2.Methods.MethodDeclaration gets confused over comments between modifier keywords
1721+
- Fixed bug [#2211] : PSR2.Methods.MethodDeclaration gets confused over comments between modifier keywords
17041722
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1705-
- Fixed bug #2212 : FUNCTION and CONST in use groups being tokenised as T_FUNCTION and T_CONST
1723+
- Fixed bug [#2212] : FUNCTION and CONST in use groups being tokenized as T_FUNCTION and T_CONST
17061724
- Thanks to [Chris Wilkinson][@thewilkybarkid] for the patch
1707-
- Fixed bug #2214 : File::getMemberProperties() is recognizing method params as properties
1725+
- Fixed bug [#2214] : File::getMemberProperties() is recognizing method params as properties
17081726
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1709-
- Fixed bug #2236 : Memory info measurement unit is Mb but probably should be MB
1710-
- Fixed bug #2246 : CSS tokenizer does not tokenize class names correctly when they contain the string NEW
1727+
- Fixed bug [#2236] : Memory info measurement unit is Mb but probably should be MB
1728+
- Fixed bug [#2246] : CSS tokenizer does not tokenize class names correctly when they contain the string NEW
17111729
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1712-
- Fixed bug #2278 : Squiz.Operators.ComparisonOperatorUsage false positive when inline IF contained in parentheses
1730+
- Fixed bug [#2278] : Squiz.Operators.ComparisonOperatorUsage false positive when inline IF contained in parentheses
17131731
- Thanks to [Arnout Boks][@aboks] for the patch
1714-
- Fixed bug #2284 : Squiz.Functions.FunctionDeclarationArgumentSpacing removing type hint during fixing
1732+
- Fixed bug [#2284] : Squiz.Functions.FunctionDeclarationArgumentSpacing removing type hint during fixing
17151733
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
1716-
- Fixed bug #2297 : Anonymous class not tokenized correctly when used as argument to another anon class
1734+
- Fixed bug [#2297] : Anonymous class not tokenized correctly when used as argument to another anon class
17171735
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
17181736

1737+
[#2109]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2109
1738+
[#2165]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2165
1739+
[#2167]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2167
1740+
[#2178]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2178
1741+
[#2190]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2190
1742+
[#2194]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2194
1743+
[#2202]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2202
1744+
[#2210]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2210
1745+
[#2211]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2211
1746+
[#2212]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2212
1747+
[#2214]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2214
1748+
[#2236]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2236
1749+
[#2246]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2246
1750+
[#2278]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2278
1751+
[#2284]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2284
1752+
[#2297]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2297
1753+
17191754
## [2.9.2] - 2018-11-08
17201755
### Changed
17211756
- PHPCS should now run under PHP 7.3 without deprecation warnings

0 commit comments

Comments
 (0)