Merge pull request #956 from PHPCSStandards/feature/generic-scopeindent-prevent-undefined-index-notice-debug-mode

jrfnl · web-flow · commit f259845d7b77 · 2025-04-13T03:30:17.000+02:00
Generic/ScopeIndent: bug fix for debug mode
diff --git a/src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php b/src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php
@@ -644,7 +644,7 @@ public function process(File $phpcsFile, $stackPtr)
                 }
 
                 $conditionToken = array_pop($openScopes);
-                if ($this->debug === true) {
+                if ($this->debug === true && $conditionToken !== null) {
                     $line = $tokens[$conditionToken]['line'];
                     $type = $tokens[$conditionToken]['type'];
                     echo "\t=> removed open scope $conditionToken ($type) on line $line".PHP_EOL;

Original file line number	Diff line number	Diff line change
`@@ -644,7 +644,7 @@ public function process(File $phpcsFile, $stackPtr)`
`644`	`644`	`}`
`645`	`645`
`646`	`646`	`$conditionToken = array_pop($openScopes);`
`647`		`- if ($this->debug === true) {`
	`647`	`+ if ($this->debug === true && $conditionToken !== null) {`
`648`	`648`	`$line = $tokens[$conditionToken]['line'];`
`649`	`649`	`$type = $tokens[$conditionToken]['type'];`
`650`	`650`	`echo "\t=> removed open scope $conditionToken ($type) on line $line".PHP_EOL;`