Skip to content

GitModified and GitStaged filters blindly expect that the git command is available #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 2 tasks
fredden opened this issue May 26, 2025 · 1 comment
Open
1 of 2 tasks

Comments

@fredden
Copy link
Member

fredden commented May 26, 2025

Is your feature request related to a problem?

When the GitModified or GitStaged filters are used, the code blindly expects that the git command-line tool is available. This results in unexpected behaviour if this assumption is not true.

Describe the solution you'd like

It would be better for end users if a suitable error message (and exit code) is presented describing the problem.

Additional context (optional)

This suggestion was initially raised in #1105 (review)

@jrfnl
Copy link
Member

jrfnl commented May 26, 2025

I wonder whether it would even make sense to do this validation as early as in the Config class ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants