Dialog: Prevent tabbing off any dialog. Fixes #3768 - Dialog: contain focus within dialog.

DavidSouther · jzaefferer · commit 3a09a4a0de1f · 2012-10-24T17:03:00.000-04:00
diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
@@ -174,9 +174,9 @@ $.widget("ui.dialog", {
 			uiDialog.bgiframe();
 		}
 
-		// prevent tabbing out of modal dialogs
+		// prevent tabbing out of dialogs
 		this._on( uiDialog, { keydown: function( event ) {
-			if ( !options.modal || event.keyCode !== $.ui.keyCode.TAB ) {
+			if ( event.keyCode !== $.ui.keyCode.TAB ) {
 				return;
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -174,9 +174,9 @@ $.widget("ui.dialog", {`
`174`	`174`	`uiDialog.bgiframe();`
`175`	`175`	`}`
`176`	`176`
`177`		`- // prevent tabbing out of modal dialogs`
	`177`	`+ // prevent tabbing out of dialogs`
`178`	`178`	`this._on( uiDialog, { keydown: function( event ) {`
`179`		`- if ( !options.modal \|\| event.keyCode !== $.ui.keyCode.TAB ) {`
	`179`	`+ if ( event.keyCode !== $.ui.keyCode.TAB ) {`
`180`	`180`	`return;`
`181`	`181`	`}`
`182`	`182`